Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include "add" button on page heading for virtual machine interfaces list #12847

Closed
Gabrielsc opened this issue Jun 9, 2023 · 3 comments · Fixed by #12864
Closed

Include "add" button on page heading for virtual machine interfaces list #12847

Gabrielsc opened this issue Jun 9, 2023 · 3 comments · Fixed by #12864
Assignees
@sudheesh001
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@Gabrielsc
Copy link

NetBox version

v3.5.3

Python version

3.9

Steps to Reproduce

  1. Click on Virtualization
  2. Click on Interfaces

Expected Behavior

I don't know if it would be exactly a bug or if something like that has already been opened (at least I didn't find it), but I believe that the "add" button previously existed in that part marked in red. At least in this version, there is this button on several other pages of the system. Sorry the English.
image

Observed Behavior

That the button existed, since items can be added.
@Gabrielsc Gabrielsc added the type: bug A confirmed report of unexpected behavior in the application label Jun 9, 2023
@Gabrielsc Gabrielsc changed the title There is no add button on the virtualization -> interface page There is no add button on the virtualization -> interfaces Jun 9, 2023
@abhi1693
Copy link
Member

abhi1693 commented Jun 9, 2023

This is not a bug and is expected.

@abhi1693 abhi1693 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2023
@Gabrielsc Gabrielsc mentioned this issue Jun 9, 2023
Closed
@arthanson
Copy link
Collaborator

I think this should be re-opened, we now have the add button in the sidebar so the add button should appear here.

@arthanson arthanson reopened this Jun 11, 2023
@sudheesh001
Copy link
Contributor

I can take this instead then during the hackathon!

sudheesh001 added a commit to sudheesh001/netbox that referenced this issue Jun 11, 2023
@sudheesh001
Fixes netbox-community#12847 - Include Missing Add buttons to Views
a1b7120 
Signed-off-by: Sudheesh Singanamalla <sudheesh@cs.washington.edu>
@sudheesh001 sudheesh001 mentioned this issue Jun 11, 2023
Merged
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application and removed type: bug A confirmed report of unexpected behavior in the application labels Jun 12, 2023
@jeremystretch jeremystretch changed the title There is no add button on the virtualization -> interfaces Include "add" button on page heading for virtual machine interfaces list Jun 12, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Jun 12, 2023
sudheesh001 added a commit to sudheesh001/netbox that referenced this issue Jun 14, 2023
@sudheesh001
Fixes netbox-community#12847 - Include Missing Add buttons to Views
c5f71c0 
Signed-off-by: Sudheesh Singanamalla <sudheesh@cs.washington.edu>
jeremystretch added a commit that referenced this issue Jun 14, 2023
@jeremystretch
Merge pull request #12864 from sudheesh001/fix/12847-include-adds
f7b0e48 
Fixes #12847 - Include Missing Add buttons to Views
jeremystretch added a commit that referenced this issue Jun 14, 2023
@jeremystretch
Changelog for #12622, #12682, #12818, #12822, #12847
4d686e8
@jeremystretch jeremystretch mentioned this issue Jun 20, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sudheesh001 sudheesh001

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #12847 - Include Missing Add buttons to Views sudheesh001/netbox
5 participants
@arthanson @sudheesh001 @abhi1693 @Gabrielsc @jeremystretch