Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ActionIngestionLog rpc #203

Merged
merged 5 commits into from
Dec 16, 2024
Merged

feat: ActionIngestionLog rpc #203

merged 5 commits into from
Dec 16, 2024

Conversation

ltucker
Copy link
Contributor

@ltucker ltucker commented Dec 16, 2024 •
edited
Loading

proto for ActionIngestionLog rpc + generated stubs

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/gen/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.21s github.com/netboxlabs/diode/diode-server/ingester 71.2% 9 0 0
🟢 PASS 1.06s github.com/netboxlabs/diode/diode-server/migrator 68.2% 4 0 0
🟢 PASS 0.02s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.67s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.48s github.com/netboxlabs/diode/diode-server/reconciler 85.0% 64 0 0
🟢 PASS 1.10s github.com/netboxlabs/diode/diode-server/reconciler/applier 88.9% 1 0 0
🟢 PASS 1.38s github.com/netboxlabs/diode/diode-server/reconciler/differ 80.9% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 79.5%

@ltucker
Copy link
Contributor Author

ltucker commented Dec 16, 2024

I generated the server end of these on the PR so we can have a feel for what the shapes it creates in golang are.

@ltucker ltucker marked this pull request as ready for review December 16, 2024 18:53
@ltucker ltucker requested a review from leoparente as a code owner December 16, 2024 18:53
@ltucker ltucker changed the base branch from develop to feat-netbox-assurance December 16, 2024 19:07
@ltucker ltucker changed the title WIP: ActionIngestionLog rpc for discussion feat: ActionIngestionLog rpc Dec 16, 2024
@ltucker ltucker merged commit 59fb526 into feat-netbox-assurance Dec 16, 2024
3 checks passed
@ltucker ltucker deleted the action_request_rpc branch December 16, 2024 19:43
mfiedorowicz pushed a commit that referenced this pull request Dec 17, 2024
@ltucker @mfiedorowicz
feat: ActionIngestionLog rpc (#203)
9a3b235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@leoparente leoparente Awaiting requested review from leoparente

Assignees
No one assigned
Labels
diode-proto diode-server go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltucker @mfiedorowicz