Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ActionIngestionLog rpc #203

Merged
merged 5 commits into from
Dec 16, 2024
Merged

feat: ActionIngestionLog rpc #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8fc170a
WIP ActionIngestionLog rpc for discussion
ltucker Dec 16, 2024
c481e36
use enum for ActionIngestLog action
ltucker Dec 16, 2024
7d0ddbc
pull out action enum to reduce verbosity
ltucker Dec 16, 2024
a436148
remove prefixing to reduce verbosity
ltucker Dec 16, 2024
15fb522
use prefixes on enums (protobuf style guide recommendation)
ltucker Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions diode-proto/diode/v1/reconciler.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,37 @@ message RetrieveIngestionLogsResponse {
string next_page_token = 3; // Token for the next page of results, if any
}

enum ActionType {
ACTION_UNSPECIFIED = 0;
ACTION_DIFF = 1;
ACTION_APPLY = 2;
ACTION_REJECT = 3;
}

// The request to take action on an ingestion log
message ActionIngestionLogRequest {
ActionType action = 1;
string ingestion_log_id = 2;
optional string branch_id = 3;
}

// The response from the ActionIngestionLog request
message ActionIngestionLogResponse {
message Error {
string message = 1;
int32 code = 2;
}
ltucker marked this conversation as resolved.
Show resolved Hide resolved

IngestionLog log = 1;
repeated Error errors = 2;
}

// Reconciler service API
service ReconcilerService {
// Retrieves ingestion data sources
rpc RetrieveIngestionDataSources(RetrieveIngestionDataSourcesRequest) returns (RetrieveIngestionDataSourcesResponse) {}
// Retrieves ingestion logs
rpc RetrieveIngestionLogs(RetrieveIngestionLogsRequest) returns (RetrieveIngestionLogsResponse);
// Takes action on an ingestion log
rpc ActionIngestionLog(ActionIngestionLogRequest) returns (ActionIngestionLogResponse);
}
Loading
Loading