Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a official helm chart repo landing page #127

Closed
wants to merge 1 commit into from
Closed

Add a official helm chart repo landing page #127

wants to merge 1 commit into from

Conversation

prologic
Copy link
Contributor

@prologic prologic commented Aug 12, 2020 •
edited
Loading

@prologic prologic changed the base branch from master to gh-pages August 12, 2020 05:40
@prologic prologic marked this pull request as ready for review August 12, 2020 05:40
@prologic prologic self-assigned this Aug 12, 2020
@prologic prologic mentioned this pull request Aug 12, 2020
Closed
ncmans
ncmans approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@ncmans ncmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to wait for helm repo PR to go in first.

@prologic
Copy link
Contributor Author

Yup I'm working on it!

@prologic
Copy link
Contributor Author

Guys we have to restructure out repo after-all. It was never created with the correct layout in the first place. I'm not certain it won't break or affect anyone's tooling that may rely on the old/wrong structure, but I have no way to be sure.

@knatsakis
Copy link
Contributor

@prologic, I would propose to go ahead and do any changes necessary.

The existing, minimal "helm repo" is not official (I believe it was never announced or discussed) and since it is for internal use only, we will fix whatever needs fixing in order to work with a proper official helm repo.

@prologic
Copy link
Contributor Author

Agreed, I will work on this tomorrow in that case. Added to my "ToDo"

@prologic prologic marked this pull request as draft September 15, 2020 05:17
@prologic
Copy link
Contributor Author

Redone and super-ceded by #152

@prologic prologic closed this Sep 29, 2020
@prologic prologic deleted the helm_chart_repo_website branch September 29, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knatsakis knatsakis knatsakis approved these changes

@ncmans ncmans ncmans approved these changes

@cakrit cakrit Awaiting requested review from cakrit

@Ferroin Ferroin Awaiting requested review from Ferroin

@ilyam8 ilyam8 Awaiting requested review from ilyam8

Assignees

@prologic prologic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prologic @knatsakis @ncmans