Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions Workflows to automate Helm Chart Releases #128

Closed
wants to merge 3 commits into from
Closed

Add Github Actions Workflows to automate Helm Chart Releases #128

wants to merge 3 commits into from

Conversation

prologic
Copy link
Contributor

@prologic prologic commented Aug 12, 2020

This now effectively gives us an official Helm Chart Repo.

Along with #127 we also have a nice looking landing page for it too!

Closes #74

@prologic prologic self-assigned this Aug 12, 2020
@prologic prologic marked this pull request as ready for review August 12, 2020 05:48
@ncmans
Copy link
Contributor

ncmans commented Aug 14, 2020

@prologic can we see if we can keep the directory structure as not to break anyone's pipeline that depends on chart being on the root of the repo.

@prologic
Copy link
Contributor Author

@prologic can we see if we can keep the directory structure as not to break anyone's pipeline that depends on chart being on the root of the repo.

I can try but that will take significant more work...

Copy link
Contributor

@ncmans ncmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try but that will take significant more work...

It shouldn't, but if it does, can you please check all references of docs to the helmchart to ensure they will continue to be valid after this PR is merged.

@prologic
Copy link
Contributor Author

Thanks @knatsakis Unfortunately this doesn't quite work yet, and I'm working with upstream on this. But I think the problem here in fact is that the structure of this repo was always wrong and we may have to change it in the end. See this comment

@kam1kaze
Copy link
Contributor

@prologic What did you decide? Are you going to change the repo structure? I think I could help with such PR that it works with the current structure.

@prologic
Copy link
Contributor Author

@prologic What did you decide? Are you going to change the repo structure? I think I could help with such PR that it works with the current structure.

I'm back on this and I will just restructure our repo to fit within the accept documented structure.

@prologic
Copy link
Contributor Author

Redone and superseded by #153

@prologic prologic closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make GitHub repo directly useable from Helm
4 participants