fix: excludedPath contained relative paths for some prerendered static files
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Skn0tt
commented
Nov 9, 2023
| @@ -74,7 +74,7 @@ Keep in mind that these will not be available on the client-side or during [prer | |||
| To test this in local development, run your Angular project using `netlify serve`: | |||
|
|
|||
| ```sh | |||
| netlify serve --dir dist/<your-project-name>/browser | |||
There was a problem hiding this comment.
this is a follow-up to #67 (comment)
|
looks like the CI needs some tending |
See https://github.com/angular/cli-builds/blob/1f309514d9f8d81fb2dfbcb163b554d79394a67c/bin/ng.js#L64# Please enter the commit message for your changes. Lines starting
|
7b8c1fb contains an update to the minimum supported version of Node.js. This could technically be seen as a breaking change, but given that Angular compilation would fail anyways on Node versions below that, I believe it's fine to put this in a patch update. |
julienp
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for detecting all files in a directory was off, and generated wrong paths. This resulted in wrong paths being excluded. This PR fixes that, and adds a very simple unit test setup to prove it.