Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: excludedPath contained relative paths for some prerendered static files #74

Merged
merged 8 commits into from
Nov 9, 2023
Merged

fix: excludedPath contained relative paths for some prerendered static files #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3a5c2e9
fix: correctly generate excludedPath + add test setup
Skn0tt Nov 9, 2023
0ddbd81
fix: remove --serve now that https://github.com/netlify/cli/pull/6138…
Skn0tt Nov 9, 2023
5d5feb2
fix: prettier
Skn0tt Nov 9, 2023
fa2cfef
fix: update node version
Skn0tt Nov 9, 2023
6c8348e
fix: for some reason, `--offline` doesn't infer the build command
Skn0tt Nov 9, 2023
7b8c1fb
fix: update minimum node version to 18.13.0, to align with Angular CLI
Skn0tt Nov 9, 2023
0de48cc
fix: excludedPath should always be posix
Skn0tt Nov 9, 2023
9b4accf
Merge branch 'main' into fix-excludedPath
Skn0tt Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: [10.13.0, '*']
node-version: [18.13.0, '*']
exclude:
- os: macOS-latest
node-version: 10.13.0
node-version: 18.13.0
- os: windows-latest
node-version: 10.13.0
node-version: 18.13.0
fail-fast: false

steps:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Keep in mind that these will not be available on the client-side or during [prer
To test this in local development, run your Angular project using `netlify serve`:

```sh
netlify serve --dir dist/<your-project-name>/browser
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a follow-up to #67 (comment)

netlify serve
```

## CLI Usage
Expand Down
18 changes: 18 additions & 0 deletions demo.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import assert from 'node:assert'
import { test } from 'node:test'

test('edge function config', async () => {
const { config } = await import('./demo/.netlify/edge-functions/angular-ssr/angular-ssr.mjs')

assert.deepEqual(config.excludedPath, [
'/dashboard/index.html',
'/favicon.ico',
'/heroes/index.html',
'/index.html',
'/main-UUT7SL5W.js',
'/polyfills-LZBJRJJE.js',
'/styles-5INURTSO.css',
'/dashboard',
'/heroes',
])
})
1 change: 1 addition & 0 deletions demo/netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[build]
command="npm run build"
ignore="exit 1" ## always build, there might be changes in the plugin

[[plugins]]
Expand Down
2 changes: 1 addition & 1 deletion demo/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading