chore: cleanup eslint (#5016)

* chore: remove custom eslint rule in favor of using built-in rule

* chore: fix parsing errors from eslint/babel in node_modules

Co-authored-by: Lukas Holzer <lukas.holzer@netlify.com>

.eslintrc.js

@@ -3,6 +3,13 @@ const { overrides } = require('@netlify/eslint-config-node')
 module.exports = {
   extends: '@netlify/eslint-config-node',
   plugins: ['sort-destructure-keys'],
+  parserOptions: {
+    babelOptions: {
+      parserOpts: {
+        sourceType: 'unambiguous',
+      },
+    },
+  },
   rules: {
     // Those rules from @netlify/eslint-config-node are currently disabled
     // TODO: remove, so those rules are enabled
@@ -32,6 +39,9 @@ module.exports = {
         sourceType: 'module',
         babelOptions: {
           presets: ['@babel/preset-react'],
+          parserOpts: {
+            sourceType: 'module',
+          },
         },
       },
       rules: {
@@ -57,6 +67,11 @@ module.exports = {
       },
       parserOptions: {
         sourceType: 'module',
+        babelOptions: {
+          parserOpts: {
+            sourceType: 'module',
+          },
+        },
       },
     },
     {
@@ -69,12 +84,14 @@ module.exports = {
     {
       files: ['src/**/*.js'],
       rules: {
-        // once a solution for npm 6 is found add this to package.json
-        // "eslint-plugin-local-rules": "file:tools/eslint-rules",
-        // add it to the plugins on top: `plugins: ['sort-destructure-keys', 'local-rules'],`
-        //
-        // after that uncomment the next line
-        // 'local-rules/no-direct-chalk-import': 2,
+        'no-restricted-modules': [
+          'error',
+          {
+            name: 'chalk',
+            message:
+              'Please use the safe chalk import that handles colors for json output. `const { chalk } = require("src/utils")`',
+          },
+        ],
       },
     },
   ],

src/utils/command-helpers.js

@@ -4,6 +4,7 @@ const os = require('os')
 const process = require('process')
 const { format, inspect } = require('util')
 
+// eslint-disable-next-line no-restricted-modules
 const { Instance: ChalkInstance } = require('chalk')
 const chokidar = require('chokidar')
 const decache = require('decache')