-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup eslint #5016
Merged
chore: cleanup eslint #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
the
type: chore
work needed to keep the product and development running smoothly
label
Aug 30, 2022
📊 Benchmark resultsComparing with 6cd52d1 Package size: 223 MB(no change)
Legend
|
eduardoboucas
previously approved these changes
Sep 27, 2022
khendrikse
previously approved these changes
Sep 27, 2022
lukasholzer
reviewed
Sep 27, 2022
// | ||
// after that uncomment the next line | ||
// 'local-rules/no-direct-chalk-import': 2, | ||
'no-restricted-modules': [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice I like cleanup!
This PR currently has a merge conflict. Please resolve this and then re-add the |
danez
dismissed stale reviews from khendrikse and eduardoboucas
via
September 27, 2022 08:54
95bfb9e
lukasholzer
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Add to Kodiak auto merge queue
type: chore
work needed to keep the product and development running smoothly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up two things with eslint:
sourceType
for babel tounambiguous
which makes babel guess the source type. This is done because we do parse node_modules for all the import rules, so that the import rules know what modules actually export. And currently, they do print warnings. With this change, they do not anymore, as babel can parse them correctly.This is the error: