Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of http client dependencies #5695

Open
lukasholzer opened this issue May 12, 2023 · 0 comments
Open

Reduce number of http client dependencies #5695

lukasholzer opened this issue May 12, 2023 · 0 comments
Labels
Ecosystem: Dev Foundations

Comments

@lukasholzer
Copy link
Collaborator

Currently, we use multiple libraries to perform HTTP requests like node-fetch and got.
To reduce our overall dependencies, let's migrate all occurrences to node-fetch as when we only have to support node 18+, we can drop the dependency and use the native node fetch.

The goal here is to reduce the installation time and the effort of maintaining multiple dependencies.
hereje added a commit to hereje/cli that referenced this issue Nov 30, 2023
@hereje
refactor: replace got with node-fetch on server.test.js
fd4fe2b 
replace got with node-fetch

related to netlify#5695
@hereje hereje mentioned this issue Nov 30, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Nov 30, 2023
@hereje
refactor: replace got with node-fetch on functions-invoke.test.ts
db30070 
replace got with node-fetch

related to netlify#5695
@hereje hereje mentioned this issue Nov 30, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Nov 30, 2023
@hereje
refactor: replace got with node-fetch on scheduled-functions.test.ts
75b39cc 
replace got with node-fetch

related to netlify#5695
@hereje hereje mentioned this issue Nov 30, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Nov 30, 2023
@hereje
refactor: replace got with node-fetch on redirects.test.ts
5314794 
replace got with node-fetch

related to netlify#5695
@hereje hereje mentioned this issue Nov 30, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Nov 30, 2023
@hereje
refactor: replace got with node-fetch on dev-miscellaneous.test.js
4248090 
related to netlify#5695
@hereje hereje mentioned this issue Nov 30, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Dec 1, 2023
@hereje
refactor: replace got with node-fetch on rules-proxy.test.ts
46251aa 
replace got with node-fetch

related to netlify#5695
@hereje hereje mentioned this issue Dec 1, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Dec 5, 2023
@hereje
refactor: replace got with node-fetch on functions-with-args.test.js
d2f807b 
related to netlify#5695
@hereje hereje mentioned this issue Dec 5, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Dec 5, 2023
@hereje
refactor: replace got with node-fetch on v2-api.test.ts
0dfffe9 
related to netlify#5695
@hereje hereje mentioned this issue Dec 5, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Dec 5, 2023
@hereje
refactor: replace got with node-fetch on hugo.test.ts
d74d29d 
related to netlify#5695
@hereje hereje mentioned this issue Dec 5, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Dec 5, 2023
@hereje
refactor: replace got with node-fetch on hugo.test.ts
95f8e2e 
related to netlify#5695
hereje added a commit to hereje/cli that referenced this issue Dec 5, 2023
@hereje
refactor: replace got with node-fetch on edge-functions.test.ts
d459930 
related to netlify#5695
@hereje hereje mentioned this issue Dec 5, 2023
Merged
5 tasks
hereje added a commit to hereje/cli that referenced this issue Dec 5, 2023
@hereje
refactor: remove got.js utility
f83e467 
remove got.js utility so that it is no longer referenced

related to netlify#5695
@hereje hereje mentioned this issue Dec 5, 2023
Closed
5 tasks
hereje added a commit to hereje/cli that referenced this issue Dec 5, 2023
@hereje
refactor: remove got dependency no longer used
16e39c1 
remove got and use node-fetch instead

related to netlify#5695
sarahetter pushed a commit that referenced this issue Dec 8, 2023
@hereje
refactor: replace got with node-fetch on redirects.test.ts (#6234)
f9c07bc 
replace got with node-fetch

related to #5695
kodiakhq bot added a commit that referenced this issue Dec 8, 2023
@hereje @kodiakhq
refactor: replace got with node-fetch on hugo.test.ts (#6247)
7e3349c 
* refactor: replace got with node-fetch on hugo.test.ts

related to #5695

* refactor: replace got with node-fetch on hugo.test.ts

related to #5695

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot added a commit that referenced this issue Dec 13, 2023
@hereje @kodiakhq
refactor: replace got with node-fetch on scheduled-functions.test.ts (#…
e3f654e 
…6233)

replace got with node-fetch

related to #5695

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot added a commit that referenced this issue Dec 13, 2023
@hereje @kodiakhq
refactor: replace got with node-fetch on functions-invoke.test.ts (#6232
8e71e42 
)

replace got with node-fetch

related to #5695

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot added a commit that referenced this issue Dec 13, 2023
@hereje @kodiakhq
refactor: replace got with node-fetch on rules-proxy.test.ts (#6236)
ef7e6db 
replace got with node-fetch

related to #5695

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot pushed a commit that referenced this issue Dec 13, 2023
@hereje @sarahetter
refactor: replace got with node-fetch on v2-api.test.ts (#6246)
8834fbc 
* refactor: run tests concurrently

* refactor: replace got with node-fetch on v2-api.test.ts

related to #5695

---------

Co-authored-by: Sarah Etter <sarah.etter@netlify.com>
sarahetter pushed a commit that referenced this issue Dec 14, 2023
@hereje @kodiakhq
refactor: replace got with node-fetch on edge-functions.test.ts (#6248)
a5740db 
related to #5695

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
khendrikse pushed a commit that referenced this issue Dec 15, 2023
@hereje @kodiakhq
refactor: replace got with node-fetch on functions-with-args.test.js (#…
64f197e 
…6245)

related to #5695

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot added a commit that referenced this issue Dec 18, 2023
@khendrikse @hereje
@kodiakhq @sarahetter
refactor: replace got with node-fetch on functions-with-args.test.js (#…
1d43172 
…6264)

* refactor: replace got with node-fetch on functions-with-args.test.js (#6245)

related to #5695

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* chore: empty commit to rerun actions

---------

Co-authored-by: Angel Mendez <amendez1988@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Sarah Etter <sarah.etter@netlify.com>
kodiakhq bot added a commit that referenced this issue Jan 11, 2024
@hereje @kodiakhq
refactor: replace got with node-fetch on server.test.js (#6231)
7ac6ae8 
replace got with node-fetch

related to #5695

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot added a commit that referenced this issue May 17, 2024
@hereje @sarahetter
@mrstork @kodiakhq
refactor: replace got with node-fetch on dev-miscellaneous.test.js (#…
5c49780 
…6235)

related to #5695

Co-authored-by: Sarah Etter <sarah.etter@netlify.com>
Co-authored-by: Mateusz Bocian <mrstork@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@svcsnyksanity svcsnyksanity mentioned this issue Oct 9, 2024
Open
@CASABECI CASABECI mentioned this issue Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Ecosystem: Dev Foundations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukasholzer