Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace got with node-fetch on functions-with-args.test.js #6264

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

khendrikse
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

This is an effort to run the proper github actions on what was originally this PR: #6245

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

…6245)

related to #5695

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@khendrikse khendrikse requested a review from a team as a code owner December 15, 2023 14:09
Copy link

github-actions bot commented Dec 15, 2023

📊 Benchmark results

Comparing with a5740db

  • Dependency count: 1,399 (no change)
  • Package size: 405 MB (no change)
  • Number of ts-expect-error directives: 1,292 (no change)

@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Dec 18, 2023
@kodiakhq kodiakhq bot merged commit 1d43172 into main Dec 18, 2023
33 checks passed
@kodiakhq kodiakhq bot deleted the kh/refactor/replace-got/functions-with-args branch December 18, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants