-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove node 12 support #5089
Conversation
📊 Benchmark resultsComparing with 4ed5916 Package size: 223 MB(no change)
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a special reason to do ^14.16.0? Because 14.15.0 was the first official 14 lts release according to the changelog
If we decide to not do 14.15 but something newer, I would suggest 14.18, because then we can already start to use the node:
protocol in our code. Although this is not really important for our code but it might become tricky if we update dependencies that support node 14 (but >=14.18) and use node:
.
|
||
**Before you begin** | ||
Make sure you have [Node.js](https://nodejs.org/en/download/) version 12.20.0, 14.14.0, 16.0.0, or later. | ||
**Before you begin** Make sure you have [Node.js](https://nodejs.org/en/download/) version 16.0.0, or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also removed 14 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea this was intentional as we want folks to install at least the current LTS 16 :) 14 will be EOL in March 2023 so there is no reason to keep install instructions on instructing for old versions.
always go with LTS.
Regarding the 14.18.x version I was thinking the same but as this is a rather new version I doubt that all folks have it installed. I would love to do that but 14.16 is already pretty old, released on 2021-02-23.
As said this should be a minimum required version. Furthermore this version was communicated in the forums post: https://answers.netlify.com/t/netlify-cli-dropping-support-for-node-js-version-12/75130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I guess we can wait for node:
for one more year :) We should change the workflow though to use node 14.16 so that in case we update dependencies that use node:
the workflow would catch that.
4c443ee
to
87f01df
Compare
🎉 Thanks for submitting a pull request! 🎉
Summary
Preparation for the Node 12 support drop we are going to to on the 27th of September
https://answers.netlify.com/t/netlify-cli-dropping-support-for-node-js-version-12/75130
engines
fields inside thepackage.json
and lock filespEvent
in favour of thenode:events
once
function see: https://nodejs.org/api/events.html#eventsonceemitter-name-optionsFor us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)