Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove node 12 support #5089

Merged
merged 4 commits into from
Sep 27, 2022
Merged

chore!: remove node 12 support #5089

merged 4 commits into from
Sep 27, 2022

Conversation

lukasholzer
Copy link
Collaborator

@lukasholzer lukasholzer commented Sep 26, 2022

🎉 Thanks for submitting a pull request! 🎉

Summary

Preparation for the Node 12 support drop we are going to to on the 27th of September

https://answers.netlify.com/t/netlify-cli-dropping-support-for-node-js-version-12/75130


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Sep 26, 2022
@github-actions
Copy link

github-actions bot commented Sep 26, 2022

📊 Benchmark results

Comparing with 4ed5916

Package size: 223 MB

(no change)

^  223 MB  223 MB  223 MB  223 MB  223 MB  223 MB  223 MB  223 MB  223 MB  223 MB  223 MB  223 MB  223 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@lukasholzer lukasholzer self-assigned this Sep 26, 2022
@lukasholzer lukasholzer marked this pull request as ready for review September 26, 2022 08:05
@lukasholzer lukasholzer requested a review from a team September 26, 2022 08:05
@lukasholzer lukasholzer requested a review from a team as a code owner September 26, 2022 08:05
jobala
jobala previously approved these changes Sep 26, 2022
khendrikse
khendrikse previously approved these changes Sep 26, 2022
Copy link
Contributor

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a special reason to do ^14.16.0? Because 14.15.0 was the first official 14 lts release according to the changelog

If we decide to not do 14.15 but something newer, I would suggest 14.18, because then we can already start to use the node: protocol in our code. Although this is not really important for our code but it might become tricky if we update dependencies that support node 14 (but >=14.18) and use node:.


**Before you begin**
Make sure you have [Node.js](https://nodejs.org/en/download/) version 12.20.0, 14.14.0, 16.0.0, or later.
**Before you begin** Make sure you have [Node.js](https://nodejs.org/en/download/) version 16.0.0, or later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removed 14 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this was intentional as we want folks to install at least the current LTS 16 :) 14 will be EOL in March 2023 so there is no reason to keep install instructions on instructing for old versions.

always go with LTS.

Regarding the 14.18.x version I was thinking the same but as this is a rather new version I doubt that all folks have it installed. I would love to do that but 14.16 is already pretty old, released on 2021-02-23.

As said this should be a minimum required version. Furthermore this version was communicated in the forums post: https://answers.netlify.com/t/netlify-cli-dropping-support-for-node-js-version-12/75130

Copy link
Contributor

@danez danez Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess we can wait for node: for one more year :) We should change the workflow though to use node 14.16 so that in case we update dependencies that use node: the workflow would catch that.

@lukasholzer lukasholzer added the automerge Add to Kodiak auto merge queue label Sep 27, 2022
@lukasholzer lukasholzer removed the automerge Add to Kodiak auto merge queue label Sep 27, 2022
@lukasholzer lukasholzer dismissed stale reviews from khendrikse and jobala via 4c443ee September 27, 2022 08:09
@lukasholzer lukasholzer force-pushed the remove-node-12-support branch from 4c443ee to 87f01df Compare September 27, 2022 08:34
@lukasholzer lukasholzer requested a review from jobala September 27, 2022 08:35
@lukasholzer lukasholzer merged commit 3ce29ee into main Sep 27, 2022
@lukasholzer lukasholzer deleted the remove-node-12-support branch September 27, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants