Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove node 12 support #5089

Merged
merged 4 commits into from
Sep 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: [12.x, '*']
node-version: [14.x, '*']
machine: ['0', '1', '2', '3', '4', '5', '6']

exclude:
- os: macOS-latest
node-version: '12.x'
node-version: '14.x'
- os: windows-latest
node-version: '12.x'
node-version: '14.x'
fail-fast: false
steps:
# Sets an output parameter if this is a release PR
Expand Down
25 changes: 17 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
![Netlify CLI](cli.png)

[![Coverage Status](https://codecov.io/gh/netlify/cli/branch/main/graph/badge.svg)](https://codecov.io/gh/netlify/cli)
[![npm version][npm-img]][npm] [![downloads][dl-img]][dl] [![netlify-status][netlify-img]][netlify] [![security][snyk-img]][snyk]
[![npm version][npm-img]][npm] [![downloads][dl-img]][dl] [![netlify-status][netlify-img]][netlify]
[![security][snyk-img]][snyk]

Interact with [Netlify](http://netlify.com/) from the comfort of your CLI.

See the [CLI command line reference](https://cli.netlify.com/commands/) to get started and the docs on using [Netlify Dev](https://github.com/netlify/cli/blob/main/docs/netlify-dev.md) to run your site locally.
See the [CLI command line reference](https://cli.netlify.com/commands/) to get started and the docs on using
[Netlify Dev](https://github.com/netlify/cli/blob/main/docs/netlify-dev.md) to run your site locally.

## Table of Contents

Expand Down Expand Up @@ -46,22 +48,28 @@ See the [CLI command line reference](https://cli.netlify.com/commands/) to get s

## Installation

Netlify CLI requires [Node.js](https://nodejs.org) version 12 or above. To install, run the following command from any directory in your terminal:
Netlify CLI requires [Node.js](https://nodejs.org) version 14 or above. To install, run the following command from any
directory in your terminal:

```bash
npm install netlify-cli -g
```

When using the CLI in a CI environment we recommend installing it locally as a development dependency, instead of globally.
To install locally, run the following command from the root directory of your project:
When using the CLI in a CI environment we recommend installing it locally as a development dependency, instead of
globally. To install locally, run the following command from the root directory of your project:

```bash
npm install --save-dev netlify-cli
```

**Important:** Running `npm install netlify-cli -g` in CI means you're always installing the latest version of the CLI, including **breaking changes**. When you install locally and use a [lock file](https://docs.npmjs.com/cli/v7/commands/npm-ci) you guarantee reproducible builds. To manage CLI updates we recommend using an automated tool like [renovate](https://github.com/renovatebot/renovate) or [dependabot](https://github.com/dependabot).
**Important:** Running `npm install netlify-cli -g` in CI means you're always installing the latest version of the CLI,
including **breaking changes**. When you install locally and use a
[lock file](https://docs.npmjs.com/cli/v7/commands/npm-ci) you guarantee reproducible builds. To manage CLI updates we
recommend using an automated tool like [renovate](https://github.com/renovatebot/renovate) or
[dependabot](https://github.com/dependabot).

Alternatively you may also use Homebrew: `brew install netlify-cli` (thanks [@cglong](https://github.com/netlify/cli/issues/291)).
Alternatively you may also use Homebrew: `brew install netlify-cli` (thanks
[@cglong](https://github.com/netlify/cli/issues/291)).

## Usage

Expand All @@ -76,7 +84,8 @@ netlify [command] help

## Documentation

To learn how to log in to Netlify and start deploying sites, visit the [documentation on Netlify](https://docs.netlify.com/cli/get-started/).
To learn how to log in to Netlify and start deploying sites, visit the
[documentation on Netlify](https://docs.netlify.com/cli/get-started/).

For a full command reference, see the list below, or visit [cli.netlify.com](https://cli.netlify.com/).

Expand Down
12 changes: 7 additions & 5 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ description: All Netlify CLI commands

# Netlify CLI Command List

Welcome to the Netlify CLI! This site provides online access to all help strings in the Netlify CLI. For a more in-depth guide, please see our [Getting Started](https://docs.netlify.com/cli/get-started/) guide on our main docs site.
Welcome to the Netlify CLI! This site provides online access to all help strings in the Netlify CLI. For a more in-depth
guide, please see our [Getting Started](https://docs.netlify.com/cli/get-started/) guide on our main docs site.

If you have questions, ideas, or would like to contribute, check out the [repository on GitHub](https://github.com/netlify/cli/).
If you have questions, ideas, or would like to contribute, check out the
[repository on GitHub](https://github.com/netlify/cli/).

**Before you begin**
Make sure you have [Node.js](https://nodejs.org/en/download/) version 12.20.0, 14.14.0, 16.0.0, or later.
**Before you begin** Make sure you have [Node.js](https://nodejs.org/en/download/) version 16.0.0, or later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removed 14 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this was intentional as we want folks to install at least the current LTS 16 :) 14 will be EOL in March 2023 so there is no reason to keep install instructions on instructing for old versions.

always go with LTS.

Regarding the 14.18.x version I was thinking the same but as this is a rather new version I doubt that all folks have it installed. I would love to do that but 14.16 is already pretty old, released on 2021-02-23.

As said this should be a minimum required version. Furthermore this version was communicated in the forums post: https://answers.netlify.com/t/netlify-cli-dropping-support-for-node-js-version-12/75130

Copy link
Contributor

@danez danez Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess we can wait for node: for one more year :) We should change the workflow though to use node 14.16 so that in case we update dependencies that use node: the workflow would catch that.


**Install the CLI**

Expand All @@ -20,7 +21,8 @@ To install the CLI, pop open your terminal and install with `npm`.
npm install netlify-cli -g
```

**Important:** When using the CLI in a CI environment we recommend installing it locally. See more [here](https://github.com/netlify/cli#installation).
**Important:** When using the CLI in a CI environment we recommend installing it locally. See more
[here](https://github.com/netlify/cli#installation).

**Listing commands**

Expand Down
Loading