refactor: tests/integration/600.framework detection.test.cjs #5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert file to esm - adjust file accordingly - update snapshots
- replace ava with vitest - run test concurrently - update snapshots
📊 Benchmark resultsComparing with 8a65ef3
|
…ework-detection.test.cjs
…ework-detection.test.cjs
|
Framework detection has changed, so there are conflicts. |
- convert file to esm - adjust file accordingly - update snapshots
- replace ava with vitest - run test concurrently - update snapshots
…tion.test.cjs' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/600.framework-detection.test.cjs
|
Another one with a weird diff |
…ework-detection.test.cjs
…ework-detection.test.cjs
…tion.test.cjs' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/600.framework-detection.test.cjs
…ework-detection.test.cjs
- convert file to esm - adjust file accordingly - update snapshots
…tion.test.cjs' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/600.framework-detection.test.cjs
…est_esm/tests/integration/600.framework-detection.test.cjs
ericapisani
added a commit
that referenced
this pull request
Oct 27, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
* refactor: convert functions/telemetry to ESM * refactor: convert commitlint config file * refactor: convert local-ip.mjs * refactor: convert 600.framework-detection test to ESM * refactor: missed removing a require statement * style: lint * refactor: convert curl.cjs to ESM * test: update file reference * refactor: convert curl.cjs to ESM * refactor: convert got.cjs to ESM * refactor: convert cli-path to ESM * fix: issues raised with linter * refactor: convert tests/integration/utils/snapshots.cjs to ESM * refactor: convert tests/integration/utils/mock-execa.cjs to ESM * style: lint * refactor: convert tests/integration/utils/external-server.cjs to ESM * refactor: convert mock-api.cjs to ESM * style: lint * style: lint * refactor: convert create-live-test-site to ESM * refactor: convert utils/dev-server.cjs to ESM * refactor: fix issues found by linter * refactor: convert utils/handle-questons.cjs to ESM * refactor: convert utils/process.cjs to ESM * refactor: convert call-cli to ESM * refactor: convert external-server-cli.cjs to ESM * refactor: convert site-builder.cjs to ESM * refactor: convert utils/pause.cjs to ESM * fix: imports * refactor: remove files that are no longer used * style: lint issues * refactor: update filenames * test: fix import * fix: import statement * fix: import statement * fix: more import statements * fix: missed a file extension * fix: specify default export * fix: export * test: see if removing the concurrency resolves the test server error * test: remove unused variable * test: try different approach to getting the dirname variable * style: lint * test: revert earlier change * test: include changes from PR #5921 * style: lint * fix: increase timeout * test: add fetch method * test: remove snapshot files that aren't used anymore * test: try asserting substring rather than snapshot * style: lint * refactor: fix export * Revert "refactor: fix export" This reverts commit 55e97b6. * test: fix snapshot test from docs change * refactor: i need more coffee
|
Closing as completed in #6092 |
hereje
deleted the
refactor_test_esm/tests/integration/600.framework-detection.test.cjs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Related to #5698
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)