Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert the rest of the project to ESM #6092

Merged
merged 61 commits into from
Oct 30, 2023
Merged

refactor: convert the rest of the project to ESM #6092

merged 61 commits into from
Oct 30, 2023

Conversation

ericapisani
Copy link
Contributor

@ericapisani ericapisani commented Oct 25, 2023 •
edited
Loading

Finish the conversion to ESM.

Also includes the changes made in #5921

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

📊 Benchmark results

Comparing with e8d4b09

  • Dependency count: 1,372 (no change)
  • Package size: 380 MB (no change)

@ericapisani
refactor: convert commitlint config file
fb03132
@ericapisani
refactor: convert local-ip.mjs
35590dc
@ericapisani
refactor: convert 600.framework-detection test to ESM
c024966
@ericapisani
refactor: missed removing a require statement
e126cf0
@ericapisani
style: lint
eb0bf01
@ericapisani
refactor: convert curl.cjs to ESM
bdbecb0
@ericapisani
test: update file reference
9ede0b3
@ericapisani
refactor: convert curl.cjs to ESM
a8a3726
@ericapisani
refactor: convert got.cjs to ESM
f885ae6
@ericapisani
refactor: convert cli-path to ESM
2397d77
@ericapisani
fix: issues raised with linter
d3a413f
@ericapisani
refactor: convert tests/integration/utils/snapshots.cjs to ESM
7c950ab
@ericapisani
refactor: convert tests/integration/utils/mock-execa.cjs to ESM
56ae13c
@ericapisani
style: lint
d0f83c7
@ericapisani
refactor: convert tests/integration/utils/external-server.cjs to ESM
964fd0f
@ericapisani
refactor: convert mock-api.cjs to ESM
e4806a0
@ericapisani
style: lint
a35bd98
@ericapisani
style: lint
b10c570
@ericapisani
refactor: convert create-live-test-site to ESM
1e60f90
@ericapisani
refactor: convert utils/dev-server.cjs to ESM
0d39762
@ericapisani
refactor: fix issues found by linter
b32bb2b
@ericapisani
refactor: convert utils/handle-questons.cjs to ESM
c4b4d68
@ericapisani
refactor: convert utils/process.cjs to ESM
666aa5d
@ericapisani
refactor: convert call-cli to ESM
1511192
@ericapisani
refactor: convert external-server-cli.cjs to ESM
a3bcc23
@ericapisani
refactor: convert site-builder.cjs to ESM
aa02c1c
@ericapisani
refactor: convert utils/pause.cjs to ESM
5059ee4
@ericapisani
fix: imports
7c09412
estephinson
estephinson suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@estephinson estephinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very small exports change, but aside from that lfg

.commitlintrc.json Show resolved Hide resolved
tests/integration/utils/snapshots.mjs Outdated Show resolved Hide resolved
estephinson
estephinson approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@estephinson estephinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets gooooooo

@ericapisani ericapisani added the automerge Add to Kodiak auto merge queue label Oct 30, 2023
@kodiakhq kodiakhq bot merged commit a1b3599 into main Oct 30, 2023
61 checks passed
@kodiakhq kodiakhq bot deleted the ericapisani/ct-69-finish-conversion-to-esm branch October 30, 2023 14:51
@sarahetter sarahetter mentioned this pull request Oct 30, 2023
Closed
5 tasks
@sarahetter sarahetter mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estephinson estephinson estephinson approved these changes

Assignees
No one assigned
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericapisani @estephinson