Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement clack DO NOT MERGE #6293

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

feat: implement clack DO NOT MERGE #6293

wants to merge 24 commits into from

Conversation

khendrikse
Copy link
Contributor

@khendrikse khendrikse commented Jan 9, 2024 •
edited
Loading

🎉 Thanks for submitting a pull request! 🎉

Summary

This is a big branch, containing all the work for https://linear.app/netlify/issue/CT-101/cli-design-system.

BEFORE MERGING, REMOVE THE GITHUB ACTIONS LOGIC THAT RUNS TESTS ON PR'S TO THIS BRANCH.

We're working on aligning the styles in the CLI. This PR contains all the work that has been done for that. But due to the enormity of the review work that would otherwise be necessary, smaller PR's will be merged into this bigger PR after being reviewed by the team, keeping the workload manageable.

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@khendrikse khendrikse self-assigned this Jan 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024 •
edited
Loading

📊 Benchmark results

Comparing with b321487

  • Dependency count: 1,299 ⬇️ 2.08% decrease vs. b321487
  • Package size: 319 MB ⬆️ 6.67% increase vs. b321487
  • Number of ts-expect-error directives: 1,061 ⬇️ 4.81% decrease vs. b321487

@khendrikse khendrikse changed the title feat: implement clack cp-101: implement clack DO NOT MERGE Jan 10, 2024
@khendrikse khendrikse changed the title cp-101: implement clack DO NOT MERGE feat: implement clack DO NOT MERGE Jan 10, 2024
@khendrikse khendrikse mentioned this pull request Jan 10, 2024
Merged
5 tasks
@khendrikse
chore: convert api command to use clack (#6294)
456caa2 
* chore: convert api command to use clack

* chore: add beginning of styleguide
This was referenced Jan 10, 2024
Merged
Merged
@khendrikse
Merge branch 'main' into CP-101/design-system-clack-implementation
5c28195
@khendrikse
chore: updates for converting the api command (#6295)
493a6a1 
* chore: improve API command with spinner and better formatting

* chore: add support for json only
@khendrikse
chore: convert unlink command (#6297)
5f03f68 
* chore: convert api command to use clack

* chore: convert unlink to use NetlifyLog
@khendrikse khendrikse mentioned this pull request Jan 12, 2024
Merged
5 tasks
@khendrikse
chore: convert link command (#6313)
5d98d73 
* chore: improve API command with spinner and better formatting

* chore: convert api command to use clack

* chore: convert link to use NetlifyLog and clack

* chore: updates for converting the api command (#6295)

* chore: improve API command with spinner and better formatting

* chore: add support for json only

* chore: more converting of link and changed json only support

* revert weird chalk helper

* chore: implement some feedback
This was referenced Jan 15, 2024
Merged
Merged
This was referenced Jan 17, 2024
Merged
Merged
lemusthelroy and others added 2 commits January 18, 2024 15:55
@lemusthelroy
feat: convert switch command to clack (#6326)
937c198 
Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
@khendrikse @lemusthelroy
chore: convert log command (#6324)
d8e422c 
* chore: convert logs:functions

* chore: convert logs:build

* chore: convert open command (#6325)

* chore: fix log tests and mocks

---------

Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
lemusthelroy and others added 6 commits January 26, 2024 14:49
@lemusthelroy @ericapisani
chore: converts watch and init commands to clack (#6346)
28ae1ed 
* chore: following all paths from watch command and converting to clack

* chore: ensuring subcommands collect messages and do not repeat intros

* chore: add style guide for child commands

* chore: add style guide for child commands

* chore: add style guide for child commands with js

* chore: remove negated condition

* chore: finish child command explanations

* chore: fix init tests by using return key instead of new line to confirm'

* chore: remove console logs

* chore: ensure create routes from init are covered and join up

* chore: fix create from template tests

* chore: remove reference to arrow keys for consistency with other select commands

* Update STYLEGUIDE.md

Co-authored-by: Erica Pisani <pisani.erica@gmail.com>

* Update STYLEGUIDE.md

Co-authored-by: Erica Pisani <pisani.erica@gmail.com>

* Update STYLEGUIDE.md

Co-authored-by: Erica Pisani <pisani.erica@gmail.com>

* Update src/commands/init/init.ts

Co-authored-by: Erica Pisani <pisani.erica@gmail.com>

---------

Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
Co-authored-by: Erica Pisani <pisani.erica@gmail.com>
@lemusthelroy @ericapisani
chore: convert sites:list and sites:delete to clack (#6350)
c674a16 
* chore: convert sites:list and sites:delete to clack

* chore: fix ternary style

* Update src/commands/sites/sites-delete.ts

Co-authored-by: Erica Pisani <pisani.erica@gmail.com>

* Update src/commands/sites/sites-delete.ts

Co-authored-by: Erica Pisani <pisani.erica@gmail.com>

* chore: remove _ from error

---------

Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
Co-authored-by: Erica Pisani <pisani.erica@gmail.com>
@lemusthelroy
Fix no git path for init command (#6357)
5a5d4ff 
Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
@lemusthelroy
chore: in progress of converting command having updated types (#6358)
76f952b 
* chore: in progress of  converting command having updated types

* chore: convert create template command to clack complete

* chore: convert create template command to clack complete

---------

Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
@lemusthelroy
chore: merge main
bf0560f
@lemusthelroy
chore: convert dev command to clack (#6366)
3f7e207 
* chore: wip convert dev command and stream logs into NetlifyLog - need to not call outro if framework

* chore: format live tunnel changes

* chore: capture all logs from @netlify/build

* chore: format styles

* chore: fix log breaking tests

* chore: log function detection with logger and remove outro

* chore: convert function registration output to clack

* chore: remove old comments from shell file

* chore: add expect-errors back

* chore: add expect-errors back

* chore: remove comment

* chore: handle formatters in console overrides

* chore: remove log

* chore: ensure tests pass where we assert what is printed for child command

* chore: ensure tests pass where we assert what is printed for child command

* chore: remove pnpm added by mistake

* In progress of fixing framework detection tests

* chore: fix snapshot tests from frameworks

* chore: fix lint issues

* chore: fix lint issues

* chore: fix lint issues

* chore: fix prettier errors

* chore: fix error not defined in addons logic

* chore: fix import order

* chore: fix empty line

* chore: fix unpublished

* chore: fix express error

---------

Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@khendrikse khendrikse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khendrikse @lemusthelroy