Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert unlink command #6297

Conversation

khendrikse
Copy link
Contributor

@khendrikse khendrikse commented Jan 10, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes: https://linear.app/netlify/issue/CT-486/convert-unlink-command-to-clack

This converts the unlink command into using the new NetlifyLog. It is part of a bigger piece of work that can be seen in #6293. This is also the reason why this PR is merged into the branch CP-101/design-system-clack-implementation. It's a way in which I'm trying to keep possible failing tests, but also the review work to a minimum amount of work for those who are reviewing.

Before:
CleanShot 2024-01-10 at 14 03 57

After:

CleanShot 2024-01-10 at 14 01 03


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@khendrikse khendrikse requested a review from a team as a code owner January 10, 2024 13:07
Base automatically changed from CP-476/convert-api-command to CP-101/design-system-clack-implementation January 11, 2024 15:40
Copy link
Contributor

@charliegroll charliegroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@khendrikse khendrikse merged commit 5f03f68 into CP-101/design-system-clack-implementation Jan 11, 2024
30 checks passed
@khendrikse khendrikse deleted the CP-486/convert-unlink-command branch January 11, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants