[MERGED] support optional catch-all routes

[rajington]

Next.js added a new, experimental, optional catch-all routes, this adds support for it by looking for one more wrapping square bracket

[FinnWoelm]

Hey @rajington,

This is excellent! Thank you so much for the PR and the contribution. 😊

This looks really good — let me take a closer look tonight and add a few tests.

Hoping to merge and publish later today! 🙂
- Finn

[FinnWoelm]

Hi @rajington,

Thanks again for this PR! I just added some tests and merged it (I rebased, so it's not showing up as merged 😐). It will go live with the next release of next-on-netlify today or tomorrow :)

Two caveats:

1. The experimental optional catch-all routes feature does not yet seem to work with pages using getStaticProps and getStaticPaths. The paths end up a bit garbled. Looks like this will be fixed in NextJS 9.4.5: make getStaticPaths work with optional catch-all routes vercel/next.js#13559

2. Ideally, I should be creating two redirects for the data routes of optional catch-all routes: one for the base path with no params and one with a * for one or more params. For the sake of simplicity, I'm just creating a single redirect for now.

   For example, a page like /shows/[[...slug]].js should have two redirects for the data routes:

   1. /_next/data/shows.json
   2. /_next/data/shows/*

   For now, I'm just using a single redirect /_next/data/shows*. This is not ideal, because this will also match /_next/data/showsButDifferent.json — which it should not match. I've made a note and hope to fix that soon.

Thank you again, @rajington! Let me know if you end up building something awesome with next-on-netlify. Would love to feature it in the README 😁

- Finn

[rajington]

will do, thanks! you're doing a great job with this project! this might be the missing piece for SSR on Netlify, wouldn't be surprised if they featured it

[FinnWoelm]

Thanks for the kind words, @rajington! It's a privilege to contribute back to the community and to meet nice people like yourself :)

I just published next-on-netlify v2.1.0 which includes your work on optional catch-all routes! 🙌

[rajington]

they did already feature it! https://www.netlify.com/blog/2020/06/10/2-ways-to-create-server-rendered-routes-using-next.js-and-netlify/