Allow the main index route to be ssg rendered with getStaticProps #18
Conversation
Previously, the / route having associated data would cause the build to fail as it would attempt to reference an /.html file instead of /index.html This also fixes a stability issue with the snapshot test for _redirects, which are not necessarily generated in a stable order.
|
Hi @etrepum, This is fantastic! Thank you for not only reporting the bug, but also diving into the code and fixing it. I really appreciate it 🙌 I've pulled the branch and am merging it locally right now (there is a minor conflict with the test snapshot). Will publish new version of Cheers, |
- Add support for [NextJS optional catch-all routes]( https://nextjs.org/docs/api-routes/dynamic-api-routes#optional-catch-all-api-routes ) ([#15](#15)) - Fix: An `index.js` page with `getStaticProps` no longer causes `next-on-netlify` to fail ([#18](#18)) - Fix: Catch-all routes now correctly require that at least one URL parameter is present (unlike optional catch-all routes) ([479b7e7](479b7e7)) - Fix: Data routes now correctly work for pages with catch-all routing ([0412b45](0412b45))
|
I just merged and published it ( I removed the part about the stability issue with the snapshot test because the order of the redirects is important. For example, more specific routes must come before less specific ones: But I hear your point about the instability of it and I will look into it — perhaps there's a solution that avoids the instability in the first place! Thank you again for your contribution, @etrepum 🙂 PS: Let me know if you build something awesome with |
|
We're working on moving our https://donate.missionbit.org/ donation portal from a standalone Flask site deployed on Azure into our new next.js site for https://www.missionbit.org/ deployed on Netlify. The source for the project is here: https://github.com/missionbit/missionbit.org Technically it's already using my branch of next-on-netlify, but it's still in a state where the output is indistinguishable from next export because there aren't any API routes yet. |
missionbit.org uses next-on-netlify, so let's feature it in the README! For details, see: #18 (comment)
|
That's an amazing site and incredible work you're doing! Super happy to have it featured in the README now: https://github.com/FinnWoelm/next-on-netlify#showcase 😊 |
Previously, the / route having associated data would cause the
build to fail as it would attempt to reference an /.html file
instead of /index.html
This also fixes a stability issue with the snapshot test for
_redirects, which are not necessarily generated in a stable order.