-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create official Netlify Remix template #83
Conversation
✅ Deploy Preview for remix-edge-on ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This reverts commit 0ff5692.
20bc577
to
480051b
Compare
45e1530
to
52fd58b
Compare
bdd6833
to
ba24c63
Compare
["server.js"], | ||
["remix.config.js"], | ||
["entry.server.tsx", "app/entry.server.tsx"], | ||
["vscode.json", ".vscode/settings.json"], | ||
]; | ||
|
||
const filesToCopy = [["README.md"], ["netlify.toml"]]; | ||
const filesToCopy = [["README.md"], ["netlify-toml", "netlify.toml"]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remix.init was ignoring *.toml files, so I renamed the template files.
I fixed the issues with the JS template generation @sarahetter @taty2010. There is one issue currently for the generation of the edge template for a JavaScript project. When the Remix CLI converts files to JS, it translates the ESM |
@@ -47,6 +47,25 @@ Open up [http://localhost:3000](http://localhost:3000), and you should be ready | |||
|
|||
Note: When running the Netlify CLI, file changes will rebuild assets, but you will not see the changes to the page you are on unless you do a browser refresh of the page. Due to how the Netlify CLI builds the Remix App Server, it does not support hot module reloading. | |||
|
|||
### Excluding routes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new section I added @stephmarie17. Could the wording be improved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion below!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏾 templates are working as expected on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Templates work, code LGTM!
Co-authored-by: Stephanie <52582720+stephmarie17@users.noreply.github.com>
Description
Updates the template. The updated template uses remix.init to offer installing Remix for Netlify Functions or for Netlify Edge Functions. The Netlify Functions template existed already within Remix, but when I was working on remix-run/remix#3104, we turned it into one template, extending the template via remix.init to choose between Netlify Functions and Netlify Edge Functions.
Ignore the deploy preview loading with a page not found. The template has changed and a deploy preview does not make sense at the moment. We'll need to rethink how we deploy the different templates as a deploy preview.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Ensure the Netlify CLI is installed and up to date.
Check out this branch, e.g. via the GitHub CLI,
gh co 83
There are four test scenarios:
For each scenario, it always starts by running the following from the root folder in a shell.
Ensure that the location is outside of the Netlify Remix template folder, e.g.
../my-remix-app
The npm packages will install.
Choose accordingly for the given test scenarios mentioned above.
../my-remix-app
.github
folderREADME.md
for the project should be for the given deployment target. If you created a new Remix app using the Netlify Functions template, it should have this README. Otherwise, it should be this README.netlify.toml
for the project should be for the given deployment target. If you created a new Remix app using the Netlify Functions template, it should have this netlify.toml. Otherwise, it should be this netlify.toml.npm install
ntl build --offline
ntl serve
https://localhost:8888
and the page loads.Testing a deployment
If you want to test a deploy of your new Remix app created by the Remix template:
or for production
For us to review and ship your PR efficiently, please perform the following steps:
can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)