fix: drop runtimeVersion override for go functions #1676

Skn0tt · 2023-12-01T08:55:20Z

Part of https://github.com/netlify/pod-dev-foundations/issues/581. provided.al2 is the default runtime for Go functions now, so we don't need the override here anymore. Put the change behind a flag, so we can rollout gradually.

github-actions · 2023-12-01T08:56:48Z

⏱ Benchmark results

Comparing with be424b2

largeDepsEsbuild: 1.4s

⬇️ 3.04% decrease vs. be424b2

^   1.5s    1.5s            1.5s    1.4s                                            1.5s    1.5s          
│   ┌──┐    ┌──┐    1.4s    ┌──┐    ┌──┐    1.4s    1.4s    1.4s    1.4s    1.4s    ┌──┐    ┌──┐    1.4s  
│   |  |    |  |    ┌──┐    |  |    |  |    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (a01ecdb): 3.1s
T-29 (97992ee): 3.4s
T-28 (d70673a): 1.5s
T-27 (cacee3f): 2.7s
T-26 (52a6654): 3.5s
T-25 (c0b0b7a): 2.7s
T-24 (15399f4): 2.7s
T-23 (ac5532d): 2.7s
T-22 (e4d0ba9): 1.5s
T-21 (234379a): 1.5s
T-20 (5fc5321): 1.5s
T-19 (fee5d2e): 1.5s
T-18 (b8a39b6): 2.6s
T-17 (06ef08f): 1.4s
T-16 (c0a64fc): 1.5s
T-15 (bcb0388): 1.5s
T-14 (5ca965f): 1.4s
T-13 (46c96e2): 1.5s
T-12 (145bc5f): 1.5s
T-11 (8ac5b33): 1.5s
T-10 (fd6c7e6): 1.4s
T-9 (1c7ce98): 1.5s
T-8 (d40e8dd): 1.4s
T-7 (dc6d7a5): 1.4s
T-6 (31faa09): 1.4s
T-5 (0f23aa8): 1.4s
T-4 (e151134): 1.4s
T-3 (f5fb309): 1.4s
T-2 (cff8955): 1.5s
T-1 (be424b2): 1.5s
T (current commit): 1.4s

largeDepsNft: 5.4s

⬇️ 6.43% decrease vs. be424b2

^                                                                                           5.8s          
│   5.5s    5.6s    5.5s    5.5s    5.6s    5.5s    5.5s    5.6s            5.4s    5.5s    ┌──┐    5.4s  
│ ──┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────5.4s────┌──┐────┌──┐────┼──┼────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (a01ecdb): 9.8s
T-29 (97992ee): 10.8s
T-28 (d70673a): 5.5s
T-27 (cacee3f): 8.7s
T-26 (52a6654): 11.1s
T-25 (c0b0b7a): 8.5s
T-24 (15399f4): 8.2s
T-23 (ac5532d): 8.5s
T-22 (e4d0ba9): 5.5s
T-21 (234379a): 5.6s
T-20 (5fc5321): 5.6s
T-19 (fee5d2e): 5.7s
T-18 (b8a39b6): 8.1s
T-17 (06ef08f): 5.5s
T-16 (c0a64fc): 5.6s
T-15 (bcb0388): 5.5s
T-14 (5ca965f): 5.5s
T-13 (46c96e2): 5.5s
T-12 (145bc5f): 5.5s
T-11 (8ac5b33): 5.6s
T-10 (fd6c7e6): 5.5s
T-9 (1c7ce98): 5.5s
T-8 (d40e8dd): 5.6s
T-7 (dc6d7a5): 5.5s
T-6 (31faa09): 5.5s
T-5 (0f23aa8): 5.6s
T-4 (e151134): 5.4s
T-3 (f5fb309): 5.4s
T-2 (cff8955): 5.5s
T-1 (be424b2): 5.8s
T (current commit): 5.4s

largeDepsZisi: 10.3s

⬇️ 2.86% decrease vs. be424b2

^  10.6s   10.5s   10.6s   10.4s   10.6s   10.4s   10.4s   10.4s           10.4s   10.5s   10.6s          
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐   10.3s    ┌──┐    ┌──┐    ┌──┐   10.3s  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (a01ecdb): 20s
T-29 (97992ee): 21.1s
T-28 (d70673a): 10.4s
T-27 (cacee3f): 17.2s
T-26 (52a6654): 21.3s
T-25 (c0b0b7a): 16.8s
T-24 (15399f4): 16.5s
T-23 (ac5532d): 16.7s
T-22 (e4d0ba9): 10.6s
T-21 (234379a): 10.6s
T-20 (5fc5321): 10.6s
T-19 (fee5d2e): 10.5s
T-18 (b8a39b6): 15.8s
T-17 (06ef08f): 10.5s
T-16 (c0a64fc): 10.5s
T-15 (bcb0388): 10.5s
T-14 (5ca965f): 10.5s
T-13 (46c96e2): 10.4s
T-12 (145bc5f): 10.6s
T-11 (8ac5b33): 10.5s
T-10 (fd6c7e6): 10.6s
T-9 (1c7ce98): 10.4s
T-8 (d40e8dd): 10.6s
T-7 (dc6d7a5): 10.4s
T-6 (31faa09): 10.4s
T-5 (0f23aa8): 10.4s
T-4 (e151134): 10.3s
T-3 (f5fb309): 10.4s
T-2 (cff8955): 10.5s
T-1 (be424b2): 10.6s
T (current commit): 10.3s

lukasholzer

🧹

…d-ship-it#1676)

fix: drop runtimeVersion override for go functions

e4e7cad

Skn0tt self-assigned this Dec 1, 2023

Skn0tt requested a review from a team as a code owner December 1, 2023 08:55

lukasholzer reviewed Dec 1, 2023

View reviewed changes

lukasholzer approved these changes Dec 1, 2023

View reviewed changes

Skn0tt merged commit f146798 into main Dec 1, 2023
10 checks passed

Skn0tt deleted the drop-runtimeversion-override branch December 1, 2023 10:41

token-generator-app bot mentioned this pull request Dec 1, 2023

chore(main): release 9.28.0 #1677

Merged

Skn0tt added a commit to netlify/build that referenced this pull request May 21, 2024

fix: drop runtimeVersion override for go functions (netlify/zip-it-an…

6dd47d8

…d-ship-it#1676)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: drop runtimeVersion override for go functions #1676

fix: drop runtimeVersion override for go functions #1676

Skn0tt commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

lukasholzer left a comment

fix: drop runtimeVersion override for go functions #1676

fix: drop runtimeVersion override for go functions #1676

Conversation

Skn0tt commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

⏱ Benchmark results

largeDepsEsbuild: 1.4s

largeDepsNft: 5.4s

largeDepsZisi: 10.3s

lukasholzer left a comment

Choose a reason for hiding this comment