DHLEX-68: resolve #5

.gitignore

@@ -1,5 +1,5 @@
 /.idea
 /composer.lock
 /vendor
-/Test/Coverage
+/test/coverage
 /coverage

src/Api/Data/RateRequestInterface.php

@@ -4,11 +4,11 @@
  */
 namespace Dhl\Express\Api\Data;
 
-use Dhl\Express\Api\Data\Request\Rate\ShipperAddressInterface;
+use Dhl\Express\Api\Data\Request\InsuranceInterface;
+use Dhl\Express\Api\Data\Request\Rate\PackageInterface;
 use Dhl\Express\Api\Data\Request\Rate\RecipientAddressInterface;
 use Dhl\Express\Api\Data\Request\Rate\ShipmentDetailsInterface;
-use Dhl\Express\Api\Data\Request\Rate\PackageInterface;
-use Dhl\Express\Api\Data\Request\InsuranceInterface;
+use Dhl\Express\Api\Data\Request\Rate\ShipperAddressInterface;
 
 /**
  * Rate Request Interface.

src/RequestBuilder/ShipmentDeleteRequestBuilder.php

@@ -4,6 +4,7 @@
  */
 namespace Dhl\Express\RequestBuilder;
 
+use DateTime;
 use Dhl\Express\Api\ShipmentDeleteRequestBuilderInterface;
 use Dhl\Express\Model\ShipmentDeleteRequest;
 
@@ -22,7 +23,7 @@ class ShipmentDeleteRequestBuilder implements ShipmentDeleteRequestBuilderInterf
      */
     private $data = [];
 
-    public function setPickupDate(\DateTime $pickupDate)
+    public function setPickupDate(DateTime $pickupDate)
     {
         $this->data['pickupDate'] = $pickupDate;
         return $this;
@@ -62,8 +63,8 @@ public function build()
             $this->data['requesterName']
         );
 
-        if (isset($this->data['reason'])) {
-            $request->setReason($this->data['reason']);
+        if (isset($this->data['reasonCode'])) {
+            $request->setReason($this->data['reasonCode']);
         }
 
         $this->data = [];

src/Webservice/Soap/ClassMap.php

@@ -42,6 +42,7 @@ public static function get()
 
             // trackShipmentRequest
             'ServiceHeader' => Type\Tracking\ServiceHeader::class,
+            'ResponseServiceHeader' => Type\Tracking\ServiceHeader::class,
             'TrackingResponse' => Type\Tracking\TrackingResponse::class,
             'Response' => Type\Tracking\Response::class,
             'AWBInfo' => Type\Tracking\AWBInfo::class,

src/Webservice/Soap/Type/ShipmentRequest/Packages/RequestedPackages.php

@@ -4,8 +4,8 @@
  */
 namespace Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Packages;
 
-use Dhl\Express\Webservice\Soap\Type\Common\Packages\RequestedPackages\Dimensions;
 use Dhl\Express\Webservice\Soap\Type\Common\Money;
+use Dhl\Express\Webservice\Soap\Type\Common\Packages\RequestedPackages\Dimensions;
 use Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Packages\RequestedPackages\CustomerReferences;
 use Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Packages\RequestedPackages\PackageContentDescription;
 use Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Packages\RequestedPackages\PieceIdentificationNumber;

src/Webservice/Soap/Type/ShipmentRequest/Ship/Address.php

@@ -4,7 +4,7 @@
  */
 namespace Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Ship;
 
-use \Dhl\Express\Webservice\Soap\Type\Common\Ship\Address as CommonAddress;
+use Dhl\Express\Webservice\Soap\Type\Common\Ship\Address as CommonAddress;
 
 /**
  * An ship address.

src/Webservice/Soap/Type/ShipmentRequest/Ship/Contact.php

@@ -4,10 +4,10 @@
  */
 namespace Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Ship;
 
-use Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Ship\Contact\PersonName;
 use Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Ship\Contact\CompanyName;
 use Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Ship\Contact\EmailAddress;
 use Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Ship\Contact\MobilePhoneNumber;
+use Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Ship\Contact\PersonName;
 use Dhl\Express\Webservice\Soap\Type\ShipmentRequest\Ship\Contact\PhoneNumber;
 
 /**

src/Webservice/Soap/Type/Tracking/PiecesEnabled.php

@@ -0,0 +1,13 @@
+<?php
+/**
+ * See LICENSE.md for license details.
+ */
+
+namespace Dhl\Express\Webservice\Soap\Type\Tracking;
+
+class PiecesEnabled
+{
+    const PIECE_AND_SHIPMENT_DETAIL = 'B';
+    const SHIPMENT_DETAIL = 'S';
+    const PIECE_DETAIL = 'P';
+}

src/Webservice/Soap/Type/Tracking/ShipmentInfo.php

@@ -60,7 +60,7 @@ class ShipmentInfo
     protected $WeightUnit;
 
     /**
-     * @var ShipmentEventCollection
+     * @var ShipmentEventCollection|null
      */
     protected $ShipmentEvent;
 
@@ -276,7 +276,7 @@ public function setWeightUnit(WeightUnit $WeightUnit)
     }
 
     /**
-     * @return ShipmentEventCollection
+     * @return ShipmentEventCollection|null
      */
     public function getShipmentEvent()
     {

src/Webservice/Soap/TypeMapper/ShipmentDeleteResponseMapper.php

@@ -7,7 +7,6 @@
 use Dhl\Express\Api\Data\ShipmentDeleteResponseInterface;
 use Dhl\Express\Exception\ShipmentDeleteRequestException;
 use Dhl\Express\Model\ShipmentDeleteResponse;
-use Dhl\Express\Webservice\Soap\Type\Common\Notification;
 use Dhl\Express\Webservice\Soap\Type\SoapShipmentDeleteResponse;
 
 /**

src/Webservice/Soap/TypeMapper/TrackingResponseMapper.php

@@ -67,18 +67,25 @@ public function map(SoapTrackingResponse $soapTrackingResponse)
                 $weight,
                 $estimatedDeliveryDate
             );
+
             $soapTrackingPieces = $soapTrackingItem->getPieces();
             $trackingPieces = [];
             if ($soapTrackingPieces !== null) {
                 /** @var PieceInterface[] $trackingPieces */
                 $trackingPieces = $soapTrackingPieces->getPieceInfo()->getArrayOfPieceInfoItem();
             }
 
+            if (($shipmentInfo !== null) && ($shipmentInfo->getShipmentEvent() instanceof ShipmentEventCollection)) {
+                $shipmentEvents = $this->convertTrackEventItems($shipmentInfo->getShipmentEvent());
+            } else {
+                $shipmentEvents = [];
+            }
+
             $trackingInfos[] = new TrackingInfo(
                 $soapTrackingItem->getAWBNumber(),
                 $soapTrackingItem->getStatus()->getActionStatus(),
                 $shipmentDetails,
-                $shipmentInfo ? $this->convertTrackEventItems($shipmentInfo->getShipmentEvent()) : [],
+                $shipmentEvents,
                 $trackingPieces
             );
         }
@@ -106,6 +113,7 @@ public function map(SoapTrackingResponse $soapTrackingResponse)
     private function convertTrackEventItems(ShipmentEventCollection $shipmentEvents)
     {
         $events = [];
+
         foreach ($shipmentEvents->getArrayOfShipmentEventItem() as $shipmentEvent) {
             $events[] = new TrackingInfo\ShipmentEvent(
                 $shipmentEvent->getDate(),

test/phpunit.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/6.2/phpunit.xsd" columns="max" stderr="true">
+         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/5.7/phpunit.xsd" columns="max" stderr="true">
     <testsuites>
         <testsuite name="DHL Express API Unit Tests">
             <directory>./Unit</directory>