-
Notifications
You must be signed in to change notification settings - Fork 22
Update tracking response #5
Update tracking response #5
Conversation
…y map response class. Added missing PiecesEnabled.php option class. Reordered some imports.
@tomazJakomin What is the difference to pull request #4? |
It contains an additional fix in mapper, because when implementing new class for ServiceHeader response I was calling wrong method on it. |
This is my first contribution on github that is why branches and pull request could be a little bit messed up to look at it. |
Hi @tomazJakomin, thank you for your contribution. If the PR #4 is outdated, then please close it. Could you please briefly describe your changes (explain the feature this PR adds / issue it fixes)? What did you want to do but couldn't prior to your changes? |
@tomazJakomin Despite your pending response I had a look at the changes. The PR seems to deal with the following issues:
Can you confirm? |
@mam08ixo I can confirm those are the issues there were fixed. |
Just a note regarding the Thank you for the contribution @tomazJakomin |
Thanks for the approvals. I will prepare another PR with some more updates soon. |
Added correct mapping for tracking response.
Reordered some imports.
Added missing option class PiecesEnabled.
It contains an additional fix in mapper, because when implementing new class for ServiceHeader response I was calling wrong method on it.