Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Update tracking response #5

Closed

Conversation

tomazJakomin
Copy link

@tomazJakomin tomazJakomin commented Feb 5, 2020

Added correct mapping for tracking response.
Reordered some imports.
Added missing option class PiecesEnabled.
It contains an additional fix in mapper, because when implementing new class for ServiceHeader response I was calling wrong method on it.

@magicsunday
Copy link
Member

@tomazJakomin What is the difference to pull request #4?

@tomazJakomin
Copy link
Author

@tomazJakomin What is the difference to pull request #4?

It contains an additional fix in mapper, because when implementing new class for ServiceHeader response I was calling wrong method on it.
It is actually pull request #4 + fix

@tomazJakomin
Copy link
Author

This is my first contribution on github that is why branches and pull request could be a little bit messed up to look at it.
I apologize and will improve in the future.

@mam08ixo
Copy link
Contributor

mam08ixo commented Feb 7, 2020

Hi @tomazJakomin, thank you for your contribution.

If the PR #4 is outdated, then please close it. Could you please briefly describe your changes (explain the feature this PR adds / issue it fixes)? What did you want to do but couldn't prior to your changes?

@mam08ixo
Copy link
Contributor

@tomazJakomin Despite your pending response I had a look at the changes. The PR seems to deal with the following issues:

  • Class Map: add missing ResponseServiceHeader type
  • Delete Shipment: fix passing Reason code from request builder to SOAP type
  • Track: introduce constants for usage in TrackingRequestBuilderInterface::setPiecesEnabled
  • Track: handle empty ShipmentEvent type during response processing

Can you confirm?

@tomazJakomin
Copy link
Author

@mam08ixo I can confirm those are the issues there were fixed.

@mam08ixo mam08ixo closed this in 702e7aa Feb 24, 2020
@mam08ixo
Copy link
Contributor

Just a note regarding the ServiceHeader and ResponseServiceHeader types: Apparently DHL Express changed the WSDL and split the original service header into two different types. With your PR, both types point to the same PHP class which offers only the common subset of fields available at the API. Good enough for me, missing fields can be added anytime if someone needs them.

Thank you for the contribution @tomazJakomin

@tomazJakomin
Copy link
Author

Thanks for the approvals.

I will prepare another PR with some more updates soon.

moehrenzahn pushed a commit that referenced this pull request Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants