Added firewall app #2
Conversation
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
There was a problem hiding this comment.
Other things look good.
This pr is blocked by networkservicemesh/sdk-vpp#291
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
There was a problem hiding this comment.
Added few comments.
In general, looks good.
Also please subscribe this repository for updates in sdk/vpp
https://github.com/networkservicemesh/sdk-vpp/blob/main/.github/workflows/update-dependent-repositories-gomod.yaml#L18
| <-vppErrCh | ||
| } | ||
|
|
||
| func exitOnErr(ctx context.Context, cancel context.CancelFunc, errCh <-chan error) { |
There was a problem hiding this comment.
@edwarnicke I see this function in many places. Can we move it into sdk/tools?
This can be done in separate PRs.
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
There was a problem hiding this comment.
One thing to complete this.
Please add docker caching as in other repos:
https://github.com/networkservicemesh/cmd-nse-supplier-k8s/blob/main/internal/pkg/imports/gen.go#L20-L22
|
Please add using of the gocahe. See at example https://github.com/networkservicemesh/cmd-forwarder-vpp/blob/main/Dockerfile#L20-L21 |
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com
Description
Made firewall nse, which filters traffic according to acl rules, provided in config file
Depends of networkservicemesh/sdk-vpp#291
Issue link
fixes networkservicemesh/sdk#952
How Has This Been Tested?
Types of changes