Fix for direct memif logic #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixaster995
force-pushed
the
fix/direct-memif
branch
3 times, most recently
from
2a9afdc to
86a3c17
Compare
Mixaster995
force-pushed
the
fix/direct-memif
branch
from
cb47e25 to
5585b65
Compare
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Mixaster995
force-pushed
the
fix/direct-memif
branch
from
650f05c to
f538ce8
Compare
|
@edwarnicke please, share your thoughts on modifications i made for memif |
9 tasks
Comment on lines
+60
to
+75
| if mechanism := memifMech.ToMechanism(conn.GetMechanism()); mechanism != nil { | ||
| // Direct memif if applicable | ||
| if memifSocketAddDel, ok := load(ctx, true); ok && m.directMemifEnabled { | ||
| _, ok := ifindex.Load(ctx, true) | ||
| if ok { | ||
| if err := del(ctx, conn, m.vppConn, true); err != nil { | ||
| _, _ = m.Close(ctx, conn) | ||
| return nil, err | ||
| } | ||
| mechanism.SetSocketFileURL((&url.URL{Scheme: memifMech.SocketFileScheme, Path: memifSocketAddDel.SocketFilename}).String()) | ||
| delete(ctx, true) | ||
| ifindex.Delete(ctx, true) | ||
| return conn, nil | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I would be suggesting to not add complexity into memif server element and create a separate chain element for directmemif.
I'm fine with these changes if @edwarnicke has no comments on them.
There was a problem hiding this comment.
I'm also inclined to a new chain element for directmemif ... but if that is not possible, lets at least default the directMemif=false
There was a problem hiding this comment.
ok, changed default value
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
denis-tingaikin
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com
Description
Refactored memif chain element and made separate element which supports direct memif logic
Issue link
fixes #287
How Has This Been Tested?
Types of changes