add ovs forwarder deployment examples #2014

pperiyasamy · 2021-07-05T12:02:34Z

adds ovs forwarder deployment examples, would help to test cmd-forwarder-ovs for which the code development is on going.

Depends on cmd-forwarder-ovs PR.

Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech

examples/ovs/README.md

Bolodya1997 · 2021-07-12T03:07:25Z

examples/use-cases/SmartVF2SmartVF/README.md

+        - name: nsc
+          env:
+            - name: NSM_NETWORK_SERVICES
+              value: kernel://icmp-responder/nsm-1?sriovToken=worker.domain/100G


We have only 10G NICs on our packet integration clusters, so this client will never start on them (if it is not somehow additionally handled in OVS forwarder).
Do you need this for some Smart VF purpose or probably it should be fixed to 10G?

This is not legacy sriov NIC and is based on Mellanox ConnectX-5 NIC (100G) which has HW offload feature enabled.
The OVS forwarder does special handling for these VFs so that OVS flows are offloaded into hardware.

@pperiyasamy We should be able to CI the example provided... the packet.net env where we have HW to run such examples only has 10G nics... is it possible to get the example to conform to what we can actually test? Feel free to talk in commentary for the example about how to alter it for MLX5 :)

@edwarnicke currently the plan is to configure the MLX5 100G NIC as per this instruction and create pci.config file and pass it as NSM_SRIOV_CONFIG_FILE into ovs forwarder. I think once this configuration is automated (like its done for legacy sriov VFs with sdk-sriov pcifunction) by enhancing sdk-sriov, then this can be easily integrated with packet.net, WDYT ?

Bolodya1997 · 2021-07-12T03:10:54Z

examples/use-cases/SmartVF2SmartVF/README.md

@@ -0,0 +1,125 @@
+# Test Smart VF connection


What is the difference with the SriovKernel2Noop use case?

I mean instead of name :)

In SmartVF2SmartVF case, both Client and Endpoint pod are attached with smart VF (on top of this PR, but design approach for End point connection is under question (i.e. one VF per client connection) and discussing other possibilities here).

So actually the actions for the both cases SriovKernel2Noop and SmartVF2SmartVF are just the same:

Request different VF resources in NSC, NSE deployments.

Request networkservice with kernel mechanism and SR-IOV token in NSC deployment.

Set service domain label in NSE deployment.

But if you are requesting 100G (instead of 10G) NIC here, there is a difference, so we actually need this new file.

@Bolodya1997 I'm not sure if MLX provides 10G NIC which has hw offload capability, we've used only 100G Connectx-5 NIC for testing. anyway this NIC is totally different from legacy SRIOV NIC and also different drivers to be bound on PFs and VFs. we can still use same sriov.conf file, but this would go into another physicalFunctions.

Bolodya1997 · 2021-07-13T09:48:33Z

LGTM, but we actually are not able to run this on our packet integration cluster, because we lack NIC needed for it. So there possibly can be problems with validating these new examples after some future NSM updates.

@edwarnicke @denis-tingaikin
Thoughts?

edwarnicke · 2021-07-20T14:14:19Z

apps/forwarder-host-ovs/forwarder.yaml

+      hostPID: true
+      hostNetwork: true
+      containers:
+        - image: networkservicemeshci/cmd-forwarder-host-ovs:latest


Typically we bind to particular version of a container (and they get updated from downstream). Could that be done here?

@edwarnicke do you want image name something like this ghcr.io/networkservicemesh/ci/cmd-forwarder-host-ovs:d7ba447 ? can we upload docker image into ghcr.io registry just with github credentials ?

@pperiyasamy Look at how we are publishing docker containers in cmd-template. Its appears you already have that, so all you'd need to do here is use your latest githash (currently 811ba56 I believe). After that update deployments should kick in and maintain it for you :)

@edwarnicke ah! ok, that's awesome. Thanks. Let me fix CI for Dockerfile.use-host-ovs in cmd-forwarder-ovs repo and then will update this PR.

done. The PR is also raised to address this so that update deployments would kick in automatically to change image version.

edwarnicke · 2021-07-20T14:14:29Z

apps/forwarder-ovs/forwarder.yaml

+      hostPID: true
+      hostNetwork: true
+      containers:
+        - image: networkservicemeshci/cmd-forwarder-ovs:latest


Typically we bind to particular version of a container (and they get updated from downstream). Could that be done here?

done as above.

denis-tingaikin · 2021-09-13T12:47:14Z

@pperiyasamy Did we merge all required PRs?

pperiyasamy · 2021-09-13T13:36:04Z

@pperiyasamy Did we merge all required PRs?

@denis-tingaikin we need to merge the following PRs.
networkservicemesh/cmd-nse-icmp-responder#286
networkservicemesh/sdk-sriov#258

denis-tingaikin

Currently, we cannot merge this due we got a red build on kind related to the last merges.

Will merge this PR when we'll fix the problem.

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

Co-authored-by: Uzlov Danil <36223296+d-uzlov@users.noreply.github.com> Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#2014 Commit: 5590380 Author: Network Service Mesh Bot Date: 2021-09-24 06:41:24 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/de… Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

pperiyasamy requested review from denis-tingaikin, edwarnicke and Bolodya1997 July 5, 2021 12:26

denis-tingaikin requested review from d-uzlov, glazychev-art and Mixaster995 July 5, 2021 12:49

Mixaster995 approved these changes Jul 6, 2021

View reviewed changes

d-uzlov reviewed Jul 6, 2021

View reviewed changes

examples/ovs/README.md Outdated Show resolved Hide resolved

pperiyasamy force-pushed the ovs-example branch from 8860535 to 2c899a9 Compare July 6, 2021 11:41

d-uzlov approved these changes Jul 6, 2021

View reviewed changes

Bolodya1997 reviewed Jul 12, 2021

View reviewed changes

edwarnicke reviewed Jul 20, 2021

View reviewed changes

pperiyasamy mentioned this pull request Jul 28, 2021

update docker-push, update-deployment ci for use-host-ovs image networkservicemesh/cmd-forwarder-ovs#7

Merged

pperiyasamy force-pushed the ovs-example branch from 2c899a9 to 6de3724 Compare August 4, 2021 10:15

pperiyasamy force-pushed the ovs-example branch from 6de3724 to a920e0b Compare August 17, 2021 11:20

pperiyasamy force-pushed the ovs-example branch from a920e0b to dda2337 Compare August 25, 2021 09:36

pperiyasamy force-pushed the ovs-example branch from dda2337 to 1961194 Compare September 1, 2021 14:06

denis-tingaikin assigned glazychev-art, Bolodya1997 and denis-tingaikin Sep 3, 2021

denis-tingaikin requested review from Bolodya1997 and edwarnicke September 3, 2021 07:53

Bolodya1997 approved these changes Sep 3, 2021

View reviewed changes

glazychev-art approved these changes Sep 9, 2021

View reviewed changes

pperiyasamy force-pushed the ovs-example branch from 1961194 to 987648c Compare September 13, 2021 10:19

pperiyasamy mentioned this pull request Sep 13, 2021

add ovs forwarder test suite networkservicemesh/integration-tests#803

Closed

denis-tingaikin approved these changes Sep 22, 2021

View reviewed changes

pperiyasamy force-pushed the ovs-example branch from 987648c to b19c4b2 Compare September 24, 2021 07:55

pperiyasamy and others added 4 commits September 24, 2021 12:09

add ovs forwarder deployment examples

fb748f4

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

Update examples/ovs/README.md

facd6b9

Co-authored-by: Uzlov Danil <36223296+d-uzlov@users.noreply.github.com> Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

update resource requirements and image path

bead4d0

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

fixes for integration tests

d81cbb5

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

pperiyasamy force-pushed the ovs-example branch from b19c4b2 to d81cbb5 Compare September 24, 2021 10:09

denis-tingaikin merged commit 4d4a689 into networkservicemesh:main Sep 27, 2021

pperiyasamy deleted the ovs-example branch September 27, 2021 10:42

nsmbot mentioned this pull request Sep 27, 2021

Update from update/networkservicemesh/deployments-k8s networkservicemesh/integration-tests#838

Merged

huly-github-staging bot unassigned Bolodya1997 and denis-tingaikin Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add ovs forwarder deployment examples #2014

add ovs forwarder deployment examples #2014

pperiyasamy commented Jul 5, 2021 •

edited

Loading

Bolodya1997 Jul 12, 2021 •

edited

Loading

pperiyasamy Jul 12, 2021

edwarnicke Jul 20, 2021

pperiyasamy Jul 27, 2021

Bolodya1997 Jul 12, 2021 •

edited

Loading

Bolodya1997 Jul 12, 2021

pperiyasamy Jul 12, 2021

Bolodya1997 Jul 13, 2021 •

edited

Loading

pperiyasamy Jul 27, 2021

Bolodya1997 commented Jul 13, 2021

edwarnicke Jul 20, 2021

pperiyasamy Jul 27, 2021

edwarnicke Jul 27, 2021

pperiyasamy Jul 27, 2021

pperiyasamy Aug 4, 2021

edwarnicke Jul 20, 2021

pperiyasamy Aug 4, 2021

denis-tingaikin commented Sep 13, 2021

pperiyasamy commented Sep 13, 2021

denis-tingaikin left a comment

add ovs forwarder deployment examples #2014

add ovs forwarder deployment examples #2014

Conversation

pperiyasamy commented Jul 5, 2021 • edited Loading

Bolodya1997 Jul 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bolodya1997 Jul 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bolodya1997 Jul 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bolodya1997 commented Jul 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denis-tingaikin commented Sep 13, 2021

pperiyasamy commented Sep 13, 2021

denis-tingaikin left a comment

Choose a reason for hiding this comment

pperiyasamy commented Jul 5, 2021 •

edited

Loading

Bolodya1997 Jul 12, 2021 •

edited

Loading

Bolodya1997 Jul 12, 2021 •

edited

Loading

Bolodya1997 Jul 13, 2021 •

edited

Loading