add connection establish check for resource pool elements #258
Conversation
pperiyasamy
requested review from
Bolodya1997,
denis-tingaikin and
edwarnicke
| @@ -65,11 +65,13 @@ func (i *resourcePoolClient) Request(ctx context.Context, request *networkservic | |||
| oldPCIAddress := request.GetConnection().GetMechanism().GetParameters()[common.PCIAddressKey] | |||
| oldTokenID := request.GetConnection().GetMechanism().GetParameters()[TokenIDKey] | |||
|
|
|||
| isEstablished := request.GetConnection().GetNextPathSegment() != nil | |||
There was a problem hiding this comment.
Is this fine for the restart scenario?
There was a problem hiding this comment.
@denis-tingaikin this is a good point, this check is just to provide do-nothing op for refresh/heal connection requests. yes, the connection state must be recovered for forwarder restart scenario, is there a way nsm mgr set isRecovery flag in connection object which would be parsed in forwarder chain elements to recover the state ? does sdk-vpp somehow do it already ?
There was a problem hiding this comment.
I suppose that in restart scenario we will have Connection.Path cleaned up on NSMgr.
There was a problem hiding this comment.
Usually for checking to see if a particular chain element has already done its work for a connection I will check some metadata for the connection that gets set after the work has been done... since the real question is "Do I have to do work or not" that may be the best choice.
There was a problem hiding this comment.
@edwarnicke as discussed resource pool chain elements are now made to use vfconfig metadata cache (this is populated by same chain element) for isEstablished check. this would cover both restart and refresh scenarios.
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
resource-reestablish-check
branch
from
b0a816f to
12c08ff
Compare
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
resource-reestablish-check
branch
from
12c08ff to
a392587
Compare
…k-sriov@main PR link: networkservicemesh/sdk-sriov#258 Commit: ea35b0f Author: Denis Tingaikin Date: 2021-09-15 11:36:26 +0300 Message: - Merge pull request #258 from Nordix/resource-reestablish-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k-sriov@main PR link: networkservicemesh/sdk-sriov#258 Commit: ea35b0f Author: Denis Tingaikin Date: 2021-09-15 11:36:26 +0300 Message: - Merge pull request #258 from Nordix/resource-reestablish-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k-sriov@main PR link: networkservicemesh/sdk-sriov#258 Commit: ea35b0f Author: Denis Tingaikin Date: 2021-09-15 11:36:26 +0300 Message: - Merge pull request #258 from Nordix/resource-reestablish-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k-sriov@main PR link: networkservicemesh/sdk-sriov#258 Commit: ea35b0f Author: Denis Tingaikin Date: 2021-09-15 11:36:26 +0300 Message: - Merge pull request #258 from Nordix/resource-reestablish-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech