Connecting a remote interface without creating a VLAN on top #5710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issue: cmd-nse-remote-vlan/18 Related PRs: sdk-vpp/546 cmd-forwarder-vpp/568 Connect external interface directly (using vlan=0) and ping from outside the cluster Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly
force-pushed
the
fix-cmd-nse-remote-vlan-18
branch
from
f469b2a to
1d7b958
Compare
edwarnicke
reviewed
May 23, 2022
| - name: NSM_CIDR_PREFIX | ||
| value: 172.10.1.0/24,100:201::/64 | ||
| value: 172.10.1.0/24 |
There was a problem hiding this comment.
Why are we clipping v6 out of the example here?
edwarnicke
reviewed
May 23, 2022
| @@ -217,7 +217,7 @@ spec: | |||
| - name: NSM_SERVICES | |||
| value: "blue-bridge.${SECOND_NAMESPACE} { vlan: 300; via: gw1 }, green-bridge.${SECOND_NAMESPACE} { vlan: 400; via: gw1 }" | |||
| - name: NSM_CIDR_PREFIX | |||
| value: 172.10.2.0/24,100:202::/64 | |||
| value: 172.10.2.0/24 | |||
There was a problem hiding this comment.
Why are we clipping v6 out of the example here?
There was a problem hiding this comment.
@edwarnicke: Currently this TC does not check IPv6 connections - can be confusing. IPv6 for nse-remote-vlan is tested by Kernel2KernelRvlanInternal
nsmbot
pushed a commit
to networkservicemesh/integration-tests
that referenced
this pull request
May 23, 2022
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#5710 Commit: 78fd1c6 Author: Network Service Mesh Bot Date: 2022-05-23 07:44:39 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/de… Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: cmd-nse-remote-vlan/18
Related PRs: sdk-vpp/546
cmd-forwarder-vpp/568
Connect external interface directly (using vlan=0) and ping from outside the cluster
Signed-off-by: Laszlo Kiraly laszlo.kiraly@est.tech