Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting a remote interface without creating a VLAN on top #546

Merged

Conversation

ljkiraly
Copy link
Contributor

@ljkiraly ljkiraly commented Apr 5, 2022

Fix issue: cmd-nse-remote-vlan/18
Do not create vlan sub-interface when VLAN-ID is set to 0

Signed-off-by: Laszlo Kiraly laszlo.kiraly@est.tech

@ljkiraly ljkiraly marked this pull request as draft April 5, 2022 10:35
@ljkiraly ljkiraly force-pushed the fix-cmd-nse-remote-vlan-18 branch 3 times, most recently from f52d190 to ca1a48c Compare April 11, 2022 15:24
@ljkiraly ljkiraly force-pushed the fix-cmd-nse-remote-vlan-18 branch 2 times, most recently from b84c879 to 11beee2 Compare April 13, 2022 10:24
Fix issue: cmd-nse-remote-vlan/networkservicemesh#18
Do not create vlan sub-interface when VLAN-ID is set to 0

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
@ljkiraly ljkiraly force-pushed the fix-cmd-nse-remote-vlan-18 branch from 11beee2 to 3033399 Compare April 13, 2022 10:24
@ljkiraly ljkiraly requested review from uablrek and zolug May 6, 2022 10:08
@ljkiraly ljkiraly marked this pull request as ready for review May 10, 2022 11:09
@ljkiraly ljkiraly requested a review from edwarnicke May 10, 2022 11:10
@edwarnicke edwarnicke merged commit 54e80e0 into networkservicemesh:main May 23, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request May 23, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#546

Commit: 54e80e0
Author: Laszlo Kiraly
Date: 2022-05-23 16:51:29 +0200
Message:
  - Connecting a remote interface without creating a VLAN on top (#546)
Fix issue: cmd-nse-remote-vlan/#18
Do not create vlan sub-interface when VLAN-ID is set to 0

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request May 23, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#546

Commit: 54e80e0
Author: Laszlo Kiraly
Date: 2022-05-23 16:51:29 +0200
Message:
  - Connecting a remote interface without creating a VLAN on top (#546)
Fix issue: cmd-nse-remote-vlan/#18
Do not create vlan sub-interface when VLAN-ID is set to 0

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request May 23, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#546

Commit: 54e80e0
Author: Laszlo Kiraly
Date: 2022-05-23 16:51:29 +0200
Message:
  - Connecting a remote interface without creating a VLAN on top (#546)
Fix issue: cmd-nse-remote-vlan/#18
Do not create vlan sub-interface when VLAN-ID is set to 0

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-simple-vl3-docker that referenced this pull request May 23, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#546

Commit: 54e80e0
Author: Laszlo Kiraly
Date: 2022-05-23 16:51:29 +0200
Message:
  - Connecting a remote interface without creating a VLAN on top (#546)
Fix issue: cmd-nse-remote-vlan/#18
Do not create vlan sub-interface when VLAN-ID is set to 0

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vl3-vpp that referenced this pull request May 23, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#546

Commit: 54e80e0
Author: Laszlo Kiraly
Date: 2022-05-23 16:51:29 +0200
Message:
  - Connecting a remote interface without creating a VLAN on top (#546)
Fix issue: cmd-nse-remote-vlan/#18
Do not create vlan sub-interface when VLAN-ID is set to 0

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request May 23, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#546

Commit: 54e80e0
Author: Laszlo Kiraly
Date: 2022-05-23 16:51:29 +0200
Message:
  - Connecting a remote interface without creating a VLAN on top (#546)
Fix issue: cmd-nse-remote-vlan/#18
Do not create vlan sub-interface when VLAN-ID is set to 0

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request May 23, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#546

Commit: 54e80e0
Author: Laszlo Kiraly
Date: 2022-05-23 16:51:29 +0200
Message:
  - Connecting a remote interface without creating a VLAN on top (#546)
Fix issue: cmd-nse-remote-vlan/#18
Do not create vlan sub-interface when VLAN-ID is set to 0

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@ljkiraly ljkiraly deleted the fix-cmd-nse-remote-vlan-18 branch May 24, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants