Floating vl3 fix #7054
Merged
Floating vl3 fix #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
floating_vl3_fix
branch
2 times, most recently
from
a1c20d7 to
651ac08
Compare
glazychev-art
requested review from
denis-tingaikin,
anastasia-malysheva and
NikitaSkrynnik
|
|
||
| bases: | ||
| - ../../../../../apps/nsc-kernel | ||
| - ../../../../../apps/nsc-kernel |
There was a problem hiding this comment.
Why don't we use refs for these resources?
There was a problem hiding this comment.
In fact, we don’t have to have refs here - it’s enough to use only the kustomization file by ref, it will be able to pick up all internal resources (by relative links)
anastasia-malysheva
approved these changes
Aug 11, 2022
anastasia-malysheva
approved these changes
Aug 11, 2022
Merged
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
floating_vl3_fix
branch
from
3b222c5 to
a9a5fe6
Compare
denis-tingaikin
approved these changes
Aug 15, 2022
nsmbot
pushed a commit
to networkservicemesh/integration-tests
that referenced
this pull request
Aug 15, 2022
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#7054 Commit: 661213c Author: Network Service Mesh Bot Date: 2022-08-15 04:32:21 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/de… Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
cmd-nse-vl3-vppimagepatch-vl3-ipam.yamlNSM_PREFIXSERVERURLIssue: #6345