Floating vl3 autoscale #7057
Merged
Floating vl3 autoscale #7057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
requested review from
denis-tingaikin,
NikitaSkrynnik and
anastasia-malysheva
| - name: nse | ||
| env: | ||
| - name: NSM_PREFIXSERVERURL | ||
| value: "tcp://$vl3_ipam_ip:5006" |
There was a problem hiding this comment.
We definitely shouldn't use static ips.
See at comment #7054 (comment)
glazychev-art
force-pushed
the
floating_vl3_autoscale
branch
from
1a1d1ec to
6953bc2
Compare
There was a problem hiding this comment.
Please resolve comment related to kubect kustomize .
And also do fixes with dupl of 'Node A' labels on the diagram. examples/floating_interdomain/usecases/FloatingVl3_autoscale/floating_vl3_autoscale.svg
Also it would be nice to add the source of the diargam into the example that allow modify the diagram in the future.
Comment on lines
73
to
76
| Save `pod-template.yaml`: | ||
| ```bash | ||
| kubectl kustomize -o 'pod-template.yaml' | ||
| ``` |
There was a problem hiding this comment.
This is looking as a complicaiton.
Could you please explain why do we need to use this?
There was a problem hiding this comment.
You are right.
Fixed
glazychev-art
force-pushed
the
floating_vl3_autoscale
branch
4 times, most recently
from
14d7633 to
0c259d1
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
floating_vl3_autoscale
branch
from
0c259d1 to
ac1bc5c
Compare
denis-tingaikin
approved these changes
Aug 25, 2022
nsmbot
pushed a commit
to networkservicemesh/integration-tests
that referenced
this pull request
Aug 25, 2022
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#7057 Commit: 02650ae Author: Network Service Mesh Bot Date: 2022-08-22 14:38:01 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/de… Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6345