Add containers log saver extension #192
Conversation
extensions/logs/suite.go
Outdated
| panic(err) | ||
| } | ||
|
|
||
| if len(result) > 0 { |
There was a problem hiding this comment.
Also, we should check that it is not only spaces
There was a problem hiding this comment.
I think this is no make sense, because each log entry contains timestamp at least. Moreover it can significantly increase processing time without obvious advantage.
There was a problem hiding this comment.
I'm not sure that kuberntes parses our logs... Please see https://kubernetes.io/docs/concepts/cluster-administration/logging/
Moreover, we cannot guarantee that all apps in our examples will use our logging system.
Moreover it can significantly increase processing time without obvious advantage.
How we can increase processing time with this?
There was a problem hiding this comment.
Well, of course we can improve filtering. But I think fully whitespaced log lines produced by NSM is an undesirable behavior and rather should be fixed, not filtered.
There was a problem hiding this comment.
Note: We'll test also the external clients and we don't know what they can do :)
I also think that check on whitespaces can be faster than save a file with whitespaces.
This can be considered in a separate PR.
Tiberivs
force-pushed
the
save-logs
branch
2 times, most recently
from
d986d7c to
192669d
Compare
extensions/multisuite/suite.go
Outdated
| func (s *Suite) WithSuits(ifaces ...interface{}) { | ||
| s.suits = make([]interface{}, len(ifaces)) | ||
| for i := range ifaces { | ||
| s.suits[i] = ifaces[i] | ||
| } | ||
| } |
There was a problem hiding this comment.
| func (s *Suite) WithSuits(ifaces ...interface{}) { | |
| s.suits = make([]interface{}, len(ifaces)) | |
| for i := range ifaces { | |
| s.suits[i] = ifaces[i] | |
| } | |
| } | |
| func (s *Suite) New(suits ...suite.TestingSuite) *Suite { | |
| return &Suite{ | |
| suits: suits | |
| } | |
| } |
Tiberivs
force-pushed
the
save-logs
branch
4 times, most recently
from
3f6db58 to
c5117a0
Compare
extensions/logs/suite.go
Outdated
| func init() { | ||
| if err := envconfig.Usage("", &config); err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| if err := envconfig.Process("", &config); err != nil { | ||
| panic(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we can use once and do lazy initialization. Also, we can do there setup for the worker pool.
|
|
||
| testStartTime time.Time | ||
| nsmContainers map[types.UID]bool | ||
| logQueue chan logItem |
There was a problem hiding this comment.
Should we use one worker pool for all suits?
Tiberivs
force-pushed
the
save-logs
branch
2 times, most recently
from
0fe2a2e to
635c386
Compare
Signed-off-by: Anatoly Loskutnikov <anatoly.loskutnikov@gmail.com>
Signed-off-by: Anatoly Loskutnikov <anatoly.loskutnikov@gmail.com>
Signed-off-by: Anatoly Loskutnikov <anatoly.loskutnikov@gmail.com>
Signed-off-by: Anatoly Loskutnikov <anatoly.loskutnikov@gmail.com>
…ployments-k8s@main networkservicemesh/deployments-k8s# networkservicemesh/deployments-k8s PR link: https://github.com/networkservicemesh/deployments-k8s/pull/ networkservicemesh/deployments-k8s commit message: commit 5dea1d6 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Mar 22 15:01:40 2021 +0700 Merge pull request #192 from Tiberivs/save-logs Add containers log saver extension Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Add
logsextension for collecting logs from containers.Needed for networkservicemesh/integration-k8s-kind#18.
Signed-off-by: Anatoly Loskutnikov anatoly.loskutnikov@gmail.com