Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix race conditions of integration-tests and update to latest deployments-k8s #236

Merged
merged 5 commits into from
Mar 24, 2021
Merged

fix race conditions of integration-tests and update to latest deployments-k8s #236

merged 5 commits into from
Mar 24, 2021

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented Mar 24, 2021 •
edited by huly-github-staging bot
Loading

Motivation

This PR reverts #192
Actually, these fixes have race conds and it is one of issues why integration-k8s-kind failing.

WARNING: DATA RACE
Write at 0x00c00010ae09 by goroutine 33:
  testing.(*common).FailNow()
      /opt/hostedtoolcache/go/1.15.10/x64/src/testing/testing.go:731 +0x4f
  testing.(*T).FailNow()
      <autogenerated>:1 +0x44
  github.com/stretchr/testify/require.NoError()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/stretchr/testify@v1.6.1/require/require.go:1038 +0x104
  github.com/networkservicemesh/integration-tests/extensions/logs.(*Suite).saveLog()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/logs/suite.go:201 +0x244
  github.com/networkservicemesh/integration-tests/extensions/logs.(*Suite).SetupSuite.func2()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/logs/suite.go:104 +0x1c8
Previous write at 0x00c00010ae09 by goroutine 82:
  testing.(*common).FailNow()
      /opt/hostedtoolcache/go/1.15.10/x64/src/testing/testing.go:731 +0x4f
  testing.(*T).FailNow()
      <autogenerated>:1 +0x44
  github.com/stretchr/testify/require.NoError()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/stretchr/testify@v1.6.1/require/require.go:1038 +0x104
  github.com/networkservicemesh/integration-tests/extensions/logs.(*Suite).saveLog()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/logs/suite.go:201 +0x244
  github.com/networkservicemesh/integration-tests/extensions/logs.(*Suite).SetupSuite.func2()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/logs/suite.go:104 +0x1c8
Goroutine 33 (running) created at:
  github.com/networkservicemesh/integration-tests/extensions/logs.(*Suite).SetupSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/logs/suite.go:101 +0x209
  github.com/networkservicemesh/integration-tests/extensions/multisuite.(*Suite).SetupSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/multisuite/suite.go:51 +0xe6
  github.com/networkservicemesh/integration-tests/extensions/base.(*Suite).SetupSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/base/suite.go:40 +0x2d8
  github.com/networkservicemesh/integration-tests/suites/basic.(*Suite).SetupSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/suites/basic/suite.gen.go:23 +0x2fc
  github.com/stretchr/testify/suite.Run()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/stretchr/testify@v1.6.1/suite/suite.go:118 +0x73b
  github.com/networkservicemesh/integration-k8s-kind.TestRunBasicSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/src/github.com/networkservicemesh/integration-k8s-kind/entry_point_test.go:34 +0x5e
  testing.tRunner()
      /opt/hostedtoolcache/go/1.15.10/x64/src/testing/testing.go:1123 +0x202
Goroutine 82 (finished) created at:
  github.com/networkservicemesh/integration-tests/extensions/logs.(*Suite).SetupSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/logs/suite.go:101 +0x209
  github.com/networkservicemesh/integration-tests/extensions/multisuite.(*Suite).SetupSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/multisuite/suite.go:51 +0xe6
  github.com/networkservicemesh/integration-tests/extensions/base.(*Suite).SetupSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/extensions/base/suite.go:40 +0x2d8
  github.com/networkservicemesh/integration-tests/suites/basic.(*Suite).SetupSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/networkservicemesh/integration-tests@v0.0.0-20210323143950-359174239f8d/suites/basic/suite.gen.go:23 +0x2fc
  github.com/stretchr/testify/suite.Run()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/pkg/mod/github.com/stretchr/testify@v1.6.1/suite/suite.go:118 +0x73b
  github.com/networkservicemesh/integration-k8s-kind.TestRunBasicSuite()
      /home/runner/work/integration-k8s-kind/integration-k8s-kind/src/github.com/networkservicemesh/integration-k8s-kind/entry_point_test.go:34 +0x5e
  testing.tRunner()
      /opt/hostedtoolcache/go/1.15.10/x64/src/testing/testing.go:1123 +0x202
==================

@denis-tingaikin
Revert "Log instance control"
ca632ef 
This reverts commit 473518c.

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
Revert "Change by request"
cf4f468 
This reverts commit 0835469.

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
Revert "Improve logs extension"
051f861 
This reverts commit 093df8b.

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
Revert "add multisuite and logs suite"
9cbad16 
This reverts commit 6ee23ec.

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
go mod tidy and update to latest deployments-k8s
867be4a 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin changed the title fix integration-tests race conditions and update to latest deploymnets-k8s fix race conditions of integration-tests and update to latest deployments-k8s Mar 24, 2021
@haiodo haiodo merged commit e424b2b into networkservicemesh:main Mar 24, 2021
nsmbot pushed a commit that referenced this pull request Mar 25, 2021
Update go.mod and go.sum to latest version from networkservicemesh/de…
5390545 
…ployments-k8s@main networkservicemesh/deployments-k8s#

networkservicemesh/deployments-k8s PR link: https://github.com/networkservicemesh/deployments-k8s/pull/

networkservicemesh/deployments-k8s commit message:
commit e424b2b
Author: Andrey Sobolev <haiodo@users.noreply.github.com>
Date:   Wed Mar 24 20:18:15 2021 +0700

    Merge pull request #236 from denis-tingaikin/fix-integration-tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this pull request Mar 25, 2021
Update go.mod and go.sum to latest version from networkservicemesh/de…
d708a88 
…ployments-k8s@main networkservicemesh/deployments-k8s#

networkservicemesh/deployments-k8s PR link: https://github.com/networkservicemesh/deployments-k8s/pull/

networkservicemesh/deployments-k8s commit message:
commit e424b2b
Author: Andrey Sobolev <haiodo@users.noreply.github.com>
Date:   Wed Mar 24 20:18:15 2021 +0700

    Merge pull request #236 from denis-tingaikin/fix-integration-tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @haiodo