Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reliability of chain element 'etcd' #523

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Improve reliability of chain element 'etcd' #523

merged 6 commits into from
Sep 24, 2024

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented Sep 12, 2024 •
edited
Loading

Closes #512

@denis-tingaikin
fix issues to resolve #512
fe4766e 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
switch to go 1.20.0
a9ef0fd 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
fix linter issues
7680956 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
fix ci issues
7cceff0 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@zolug
Copy link

zolug commented Sep 13, 2024

I wonder when using sdk/pkg/registry/core/chain's NewNetworkServiceEndpointRegistryClient to get a client to watch NSEs that belong to a particular NS, how should one avoid missing Delete events in case loss of nsmgr or registry handling the find? (Assuming the NSE registration/unregistration is served by a different registry and nsmgr.)

@NikitaSkrynnik NikitaSkrynnik mentioned this pull request Sep 17, 2024
Open
@denis-tingaikin denis-tingaikin mentioned this pull request Sep 24, 2024
Open
@denis-tingaikin
Copy link
Member Author

I wonder when using sdk/pkg/registry/core/chain's NewNetworkServiceEndpointRegistryClient to get a client to watch NSEs that belong to a particular NS, how should one avoid missing Delete events in case loss of nsmgr or registry handling the find? (Assuming the NSE registration/unregistration is served by a different registry and nsmgr.)

True, and since it's related to the client side, I've created a separate ticket to consider the problem on the client side networkservicemesh/sdk#1671

@denis-tingaikin
apply review comments
c20c735 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
fix yaml linter issue
4bd317f 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit e3a1092 into main Sep 24, 2024
11 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-ovs that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
530d901 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-exclude-prefixes-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1477e20 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7f19d3d 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bb83cb7 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c499be0 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
85d720a 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-supplier-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
56099d6 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
nsmbot added a commit to networkservicemesh/cmd-registry-k8s that referenced this pull request Sep 24, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e16db2b 
…k-k8s@main (#478)

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nse-supplier-k8s that referenced this pull request Sep 24, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
30a07ff 
…k-k8s@main (#352)

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Sep 24, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8f127de 
…k-k8s@main (#461)

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-exclude-prefixes-k8s that referenced this pull request Sep 24, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
897150e 
…k-k8s@main (#316)

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
145da7c 
…d-registry-k8s@main

PR link: networkservicemesh/cmd-registry-k8s#478

Commit: e16db2b
Author: Network Service Mesh Bot
Date: 2024-09-24 09:56:48 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#478)
PR link: networkservicemesh/sdk-k8s#523
Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
    - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Sep 24, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d1996c2 
…k-k8s@main (#770)

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-forwarder-ovs that referenced this pull request Sep 24, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
35f6d5e 
…k-k8s@main (#412)

PR link: networkservicemesh/sdk-k8s#523

Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
  - Merge pull request #523 from networkservicemesh/reliable-watch

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
8c26ee2 
…d-admission-webhook-k8s@main

PR link: networkservicemesh/cmd-admission-webhook-k8s#461

Commit: 8f127de
Author: Network Service Mesh Bot
Date: 2024-09-24 09:57:05 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#461)
PR link: networkservicemesh/sdk-k8s#523
Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
    - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
af2e230 
…d-exclude-prefixes-k8s@main

PR link: networkservicemesh/cmd-exclude-prefixes-k8s#316

Commit: 897150e
Author: Network Service Mesh Bot
Date: 2024-09-24 09:57:09 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#316)
PR link: networkservicemesh/sdk-k8s#523
Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
    - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
776bcef 
…d-nse-supplier-k8s@main

PR link: networkservicemesh/cmd-nse-supplier-k8s#352

Commit: 30a07ff
Author: Network Service Mesh Bot
Date: 2024-09-24 09:57:05 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#352)
PR link: networkservicemesh/sdk-k8s#523
Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
    - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
1fc01c0 
…d-forwarder-sriov@main

PR link: networkservicemesh/cmd-forwarder-sriov#770

Commit: d1996c2
Author: Network Service Mesh Bot
Date: 2024-09-24 09:57:11 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#770)
PR link: networkservicemesh/sdk-k8s#523
Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
    - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Sep 24, 2024
Merged
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 24, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
dd29b83 
…d-forwarder-ovs@main

PR link: networkservicemesh/cmd-forwarder-ovs#412

Commit: 35f6d5e
Author: Network Service Mesh Bot
Date: 2024-09-24 09:57:13 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#412)
PR link: networkservicemesh/sdk-k8s#523
Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
    - Merge pull request #523 from networkservicemesh/reliable-watch
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Sep 24, 2024
Merged
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 24, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
15a9a39 
…d-nse-supplier-k8s@main (#12303)

PR link: networkservicemesh/cmd-nse-supplier-k8s#352

Commit: 30a07ff
Author: Network Service Mesh Bot
Date: 2024-09-24 09:57:05 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#352)
PR link: networkservicemesh/sdk-k8s#523
Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
    - Merge pull request #523 from networkservicemesh/reliable-watch

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 24, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
b65c9b0 
…d-registry-k8s@main (#12314)

PR link: networkservicemesh/cmd-registry-k8s#478

Commit: e16db2b
Author: Network Service Mesh Bot
Date: 2024-09-24 09:56:48 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#478)
PR link: networkservicemesh/sdk-k8s#523
Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
    - Merge pull request #523 from networkservicemesh/reliable-watch

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 24, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
dc67a4e 
…d-forwarder-sriov@main (#12313)

PR link: networkservicemesh/cmd-forwarder-sriov#770

Commit: d1996c2
Author: Network Service Mesh Bot
Date: 2024-09-24 09:57:11 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#770)
PR link: networkservicemesh/sdk-k8s#523
Commit: e3a1092
Author: Ed Warnicke
Date: 2024-09-24 09:53:20 -0500
Message:
    - Merge pull request #523 from networkservicemesh/reliable-watch

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
@zolug
Copy link

zolug commented Sep 24, 2024 •
edited
Loading

Built a k8s-registry on 1.13.2 for a quick try.
Seems nses CRs including the forwarders keep getting removed from the system when reaching 60seconds lifetime.

For me its seems that register simply uses the nse returned by client.Get() for update instead of the one in the request, thus the expiration time won't be updated.

@denis-tingaikin denis-tingaikin self-assigned this Sep 25, 2024
@denis-tingaikin denis-tingaikin mentioned this pull request Sep 30, 2024
Merged
@denis-tingaikin
Copy link
Member Author

@zolug Many thanks for finding this. Indeed the problem was with refreshing content of crd resources. Fix is here #527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zolug zolug zolug left review comments

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees

@denis-tingaikin denis-tingaikin

Labels
None yet
Projects
Release v1.14.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

etcd Find seems unreliable when watch is enabled
3 participants
@denis-tingaikin @zolug @edwarnicke