fix problem with updating nsm crd resources #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-etcd-ifcase-update
branch
from
ec6f50c
to
afd76af
Compare
ljkiraly
reviewed
Sep 30, 2024
| require.NoError(t, err) | ||
|
|
||
| // 3. Check new client request | ||
| nsc = domain.Nodes[0].NewClient(ctx, sandbox.GenerateTestToken) |
There was a problem hiding this comment.
Am I right in understanding that here we test an NSC restart, reconnect with same connection ID?
There was a problem hiding this comment.
As I can see by default it will generate a new connection id. See at https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/client/client.go#L43 -> https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/client/client.go#L55
| require.NoError(t, err) | ||
|
|
||
| require.Eventually(t, func() bool { | ||
| return counter.Requests() >= 3 |
There was a problem hiding this comment.
In which case the Request count >3 is acceptable? (the =3 is evident)
There was a problem hiding this comment.
Since the client is using retry chain element, it could produce more than 3 requests while the registry is restarting.
| @@ -131,7 +131,7 @@ func (n *etcdNSRegistryServer) sendEvent(resp *registry.NetworkServiceResponse) | |||
|
|
|||
| func (n *etcdNSRegistryServer) Register(ctx context.Context, request *registry.NetworkService) (*registry.NetworkService, error) { | |||
| meta := metav1.ObjectMeta{ | |||
| GenerateName: "nse-", | |||
| GenerateName: "netsvc-", | |||
There was a problem hiding this comment.
Can this change cause compatibility issues during upgrade?
There was a problem hiding this comment.
I believe it's can't produce compatibility issues, it's related to case when applied network service via NSM api without a name.
nsmbot
pushed a commit
to networkservicemesh/cmd-exclude-prefixes-k8s
that referenced
this pull request
Oct 1, 2024
…k-k8s@main PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Oct 1, 2024
…k-k8s@main PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Oct 1, 2024
…k-k8s@main PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
Oct 1, 2024
…k-k8s@main PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
Oct 1, 2024
…k-k8s@main PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-k8s
that referenced
this pull request
Oct 1, 2024
…k-k8s@main PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Oct 1, 2024
…k-k8s@main PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 1, 2024
nsmbot
added a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Oct 1, 2024
…k-k8s@main (#773) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-registry-k8s
that referenced
this pull request
Oct 1, 2024
…k-k8s@main (#480) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
Oct 1, 2024
…k-k8s@main (#354) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Oct 1, 2024
…k-k8s@main (#463) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 1, 2024
…d-forwarder-sriov@main PR link: networkservicemesh/cmd-forwarder-sriov#773 Commit: 0c2ec1c Author: Network Service Mesh Bot Date: 2024-09-30 20:52:12 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#773) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 1, 2024
…d-registry-k8s@main PR link: networkservicemesh/cmd-registry-k8s#480 Commit: 3358a66 Author: Network Service Mesh Bot Date: 2024-09-30 20:52:17 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#480) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 1, 2024
…d-nse-supplier-k8s@main PR link: networkservicemesh/cmd-nse-supplier-k8s#354 Commit: 818d038 Author: Network Service Mesh Bot Date: 2024-09-30 20:52:22 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#354) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 1, 2024
…d-admission-webhook-k8s@main PR link: networkservicemesh/cmd-admission-webhook-k8s#463 Commit: 220a756 Author: Network Service Mesh Bot Date: 2024-09-30 20:52:28 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#463) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
Oct 1, 2024
…k-k8s@main (#415) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-exclude-prefixes-k8s
that referenced
this pull request
Oct 1, 2024
…k-k8s@main (#318) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 1, 2024
…d-forwarder-ovs@main PR link: networkservicemesh/cmd-forwarder-ovs#415 Commit: fa90e2e Author: Network Service Mesh Bot Date: 2024-09-30 20:52:43 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#415) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 1, 2024
…d-exclude-prefixes-k8s@main PR link: networkservicemesh/cmd-exclude-prefixes-k8s#318 Commit: 8991372 Author: Network Service Mesh Bot Date: 2024-09-30 20:52:43 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#318) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 1, 2024
…d-nse-supplier-k8s@main (#12322) PR link: networkservicemesh/cmd-nse-supplier-k8s#354 Commit: 818d038 Author: Network Service Mesh Bot Date: 2024-09-30 20:52:22 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#354) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 1, 2024
…d-forwarder-sriov@main (#12332) PR link: networkservicemesh/cmd-forwarder-sriov#773 Commit: 0c2ec1c Author: Network Service Mesh Bot Date: 2024-09-30 20:52:12 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#773) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 1, 2024
…d-registry-k8s@main (#12333) PR link: networkservicemesh/cmd-registry-k8s#480 Commit: 3358a66 Author: Network Service Mesh Bot Date: 2024-09-30 20:52:17 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#480) PR link: networkservicemesh/sdk-k8s#527 Commit: cac9089 Author: Ed Warnicke Date: 2024-09-30 20:48:37 -0500 Message: - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #523 (comment) and networkservicemesh/integration-k8s-kind#1032