use source address for ping to check if the connection is alive #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
livenesscheck_source
branch
from
814d43e to
614f7bf
Compare
denis-tingaikin
approved these changes
Mar 21, 2023
glazychev-art
force-pushed
the
livenesscheck_source
branch
2 times, most recently
from
9527e5a to
64b796a
Compare
glazychev-art
force-pushed
the
livenesscheck_source
branch
from
64b796a to
bf26737
Compare
denis-tingaikin
approved these changes
May 18, 2023
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
livenesscheck_source
branch
from
bf26737 to
26645b0
Compare
denis-tingaikin
approved these changes
May 18, 2023
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
May 18, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#535 Commit: 6f7d01e Author: Denis Tingaikin Date: 2023-05-18 17:07:02 +0300 Message: - Merge pull request #535 from glazychev-art/livenesscheck_source Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
May 18, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#535 Commit: 6f7d01e Author: Denis Tingaikin Date: 2023-05-18 17:07:02 +0300 Message: - Merge pull request #535 from glazychev-art/livenesscheck_source Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-l7-proxy
that referenced
this pull request
May 18, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#535 Commit: 6f7d01e Author: Denis Tingaikin Date: 2023-05-18 17:07:02 +0300 Message: - Merge pull request #535 from glazychev-art/livenesscheck_source Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: networkservicemesh/integration-k8s-packet#306
Now we specify the source address to determine which interface to use for checking.
Moved the check to goroutines, because with several addresses (src and dst) it is incorrect to divide the timeout.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com