[sdk-vpp#314] Incorporate SR-IOV forwarder chain into xconnectns #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolodya1997
force-pushed
the
sdk-vpp#314/sriov-forwarder
branch
2 times, most recently
from
75fca3d to
e847e9b
Compare
9 tasks
9 tasks
edwarnicke
reviewed
Aug 17, 2021
| noopmech.MECHANISM: noopChains.beforeConnectServer, | ||
| }), | ||
| ), | ||
| forwarder.WithConnectClients( |
There was a problem hiding this comment.
Is there a reason we are doing this Switch at the top level instead of simply rolling it under the kernel mechanism (for kernel) and creating a new mechanism/vfio (for vfio)?
There was a problem hiding this comment.
We have different underlying mechanisms for providing kernel interface in VPP case and in SR-IOV case.
Actually, SR-IOV kernel is mostly like VFIO, not like VPP kernel - because we need to select VF by token, bound kernel driver for the VF (same part) and then configure IP address, routes in kernel way, not in VPP way (kernel-specific part).
Bolodya1997
force-pushed
the
sdk-vpp#314/sriov-forwarder
branch
from
e847e9b to
161cbe8
Compare
added 2 commits
September 3, 2021 15:23
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
sdk-vpp#314/sriov-forwarder
branch
from
161cbe8 to
70d7b53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorporates SR-IOV forwarder chain into xconnectns.
Depends on networkservicemesh/sdk#1045.Depends on networkservicemesh/sdk#1047.Depends on networkservicemesh/api#110.
Needs to be manually tested before merging.Depends on networkservicemesh/sdk-sriov#227.
Issue link
Needed for #314.
How Has This Been Tested?
Types of changes