Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk-vpp#314] Add switch-case chain elements #1046

Merged
merged 3 commits into from
Aug 18, 2021
Merged

[sdk-vpp#314] Add switch-case chain elements #1046

merged 3 commits into from
Aug 18, 2021

Conversation

Bolodya1997
Copy link

Description

Adds switch-case chain elements.

Issue link

Needed for networkservicemesh/sdk-vpp#314.

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@Bolodya1997 Bolodya1997 marked this pull request as draft July 29, 2021 12:18
@Bolodya1997 Bolodya1997 force-pushed the sdk-vpp#314/condition branch 2 times, most recently from 473cf1d to 170ca4a Compare July 29, 2021 14:58
@Bolodya1997 Bolodya1997 marked this pull request as ready for review July 29, 2021 15:05
@d-uzlov
Copy link
Contributor

d-uzlov commented Jul 29, 2021

This doesn't seem related to vpp.
While right now we don't need it anywhere else, maybe we should still put this into main sdk?

@Bolodya1997
Copy link
Author

This doesn't seem related to vpp.
While right now we don't need it anywhere else, maybe we should still put this into main sdk?

This is actually a PR to sdk :)

@d-uzlov
Copy link
Contributor

d-uzlov commented Jul 29, 2021

Oh, I was confused by the PR name :)

@Bolodya1997 Bolodya1997 mentioned this pull request Jul 30, 2021
Closed
9 tasks
denis-tingaikin
denis-tingaikin requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split refactoring and bug fixing?

@Bolodya1997
Copy link
Author

Bolodya1997 commented Aug 13, 2021 •
edited
Loading

@denis-tingaikin
It is needed for networkservicemesh/sdk-vpp#325.

@Bolodya1997 Bolodya1997 force-pushed the sdk-vpp#314/condition branch from 253c2d5 to 9eef9b2 Compare August 16, 2021 04:15
@edwarnicke
Copy link
Member

Overall I can see the utility of Switch chain element in many cases, including NSEs providing multiple NSes, etc.

@denis-tingaikin
Copy link
Member

@edwarnicke , @Bolodya1997

Hm... Can we use switchcase chain element instead of mechanisms?

What do you think?

@edwarnicke
Copy link
Member

Hm... Can we use switchcase chain element instead of mechanisms?

What do you think?

@denis-tingaikin That is a very interesting idea actually :)

@edwarnicke edwarnicke mentioned this pull request Aug 17, 2021
Draft
9 tasks
Vladimir Popov added 2 commits August 18, 2021 16:05
Add switch-case server, client chain elements
576eb22 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Rename swich package to switchcase
92f375b 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 force-pushed the sdk-vpp#314/condition branch from 9eef9b2 to f7b704d Compare August 18, 2021 09:08
@Bolodya1997
Copy link
Author

@edwarnicke , @Bolodya1997

Hm... Can we use switchcase chain element instead of mechanisms?

What do you think?

mechanisms server does iterating over all mechanism preferences, so it cannot be simply replaced with switchcase.

Rework switchcase to call next
583fb4c 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 force-pushed the sdk-vpp#314/condition branch from f7b704d to 583fb4c Compare August 18, 2021 09:14
denis-tingaikin
denis-tingaikin approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwarnicke edwarnicke merged commit 51c735c into networkservicemesh:main Aug 18, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Aug 18, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5f746b1 
…k@main

PR link: networkservicemesh/sdk#1046

Commit: 51c735c
Author: Vladimir Popov
Date: 2021-08-18 21:14:40 +0700
Message:
  - [sdk-vpp#314] Add switch-case chain elements (#1046)
* Add switch-case server, client chain elements

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rename swich package to switchcase

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework switchcase to call next

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 18, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7b729a1 
…k@main

PR link: networkservicemesh/sdk#1046

Commit: 51c735c
Author: Vladimir Popov
Date: 2021-08-18 21:14:40 +0700
Message:
  - [sdk-vpp#314] Add switch-case chain elements (#1046)
* Add switch-case server, client chain elements

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rename swich package to switchcase

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework switchcase to call next

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Aug 18, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0706740 
…k@main

PR link: networkservicemesh/sdk#1046

Commit: 51c735c
Author: Vladimir Popov
Date: 2021-08-18 21:14:40 +0700
Message:
  - [sdk-vpp#314] Add switch-case chain elements (#1046)
* Add switch-case server, client chain elements

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rename swich package to switchcase

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework switchcase to call next

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Aug 18, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cbe0740 
…k@main

PR link: networkservicemesh/sdk#1046

Commit: 51c735c
Author: Vladimir Popov
Date: 2021-08-18 21:14:40 +0700
Message:
  - [sdk-vpp#314] Add switch-case chain elements (#1046)
* Add switch-case server, client chain elements

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rename swich package to switchcase

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework switchcase to call next

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Aug 18, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a2a2a2b 
…k@main

PR link: networkservicemesh/sdk#1046

Commit: 51c735c
Author: Vladimir Popov
Date: 2021-08-18 21:14:40 +0700
Message:
  - [sdk-vpp#314] Add switch-case chain elements (#1046)
* Add switch-case server, client chain elements

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rename swich package to switchcase

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework switchcase to call next

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Aug 18, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f225f95 
…k@main

PR link: networkservicemesh/sdk#1046

Commit: 51c735c
Author: Vladimir Popov
Date: 2021-08-18 21:14:40 +0700
Message:
  - [sdk-vpp#314] Add switch-case chain elements (#1046)
* Add switch-case server, client chain elements

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rename swich package to switchcase

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework switchcase to call next

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 18, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f4c896b 
…k@main

PR link: networkservicemesh/sdk#1046

Commit: 51c735c
Author: Vladimir Popov
Date: 2021-08-18 21:14:40 +0700
Message:
  - [sdk-vpp#314] Add switch-case chain elements (#1046)
* Add switch-case server, client chain elements

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rename swich package to switchcase

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework switchcase to call next

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Aug 18, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b841101 
…k@main

PR link: networkservicemesh/sdk#1046

Commit: 51c735c
Author: Vladimir Popov
Date: 2021-08-18 21:14:40 +0700
Message:
  - [sdk-vpp#314] Add switch-case chain elements (#1046)
* Add switch-case server, client chain elements

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rename swich package to switchcase

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework switchcase to call next

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Aug 18, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3677c16 
…k@main

PR link: networkservicemesh/sdk#1046

Commit: 51c735c
Author: Vladimir Popov
Date: 2021-08-18 21:14:40 +0700
Message:
  - [sdk-vpp#314] Add switch-case chain elements (#1046)
* Add switch-case server, client chain elements

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rename swich package to switchcase

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework switchcase to call next

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 18, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@denis-tingaikin denis-tingaikin mentioned this pull request Sep 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@d-uzlov d-uzlov d-uzlov approved these changes

@Mixaster995 Mixaster995 Mixaster995 approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Bolodya1997 @d-uzlov @edwarnicke @denis-tingaikin @glazychev-art @Mixaster995