Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issues caused by moving to Go generics #1420

Closed
wazsone opened this issue Feb 14, 2023 · 1 comment
Closed

Fix CI issues caused by moving to Go generics #1420

wazsone opened this issue Feb 14, 2023 · 1 comment
Assignees
@wazsone
Labels
bug Something isn't working

Comments

@wazsone
Copy link
Contributor

wazsone commented Feb 14, 2023 •
edited
Loading

Related to #1419
@wazsone wazsone self-assigned this Feb 14, 2023
@denis-tingaikin denis-tingaikin moved this to In Progress in Release v1.8.0 Feb 14, 2023
@denis-tingaikin denis-tingaikin added the bug Something isn't working label Feb 14, 2023
This was referenced Feb 14, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@NikitaSkrynnik NikitaSkrynnik moved this from In Progress to Under review in Release v1.8.0 Feb 16, 2023
This was referenced Feb 17, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@denis-tingaikin
Copy link
Member

denis-tingaikin commented Feb 18, 2023 •
edited
Loading

@wazsone Before we close it, please lets minimalize scope of disabling revive linter.

Please add text field for the added exclude-rules section.

   exclude-rules:
    - path: main.go
      linters:
        - revive
      text: "`TODO: Add error text about the comment for the main package.`"

This was referenced Feb 20, 2023
Merged
Merged
Merged
This was referenced Feb 20, 2023
Merged
Merged
Merged
@wazsone wazsone closed this as completed Feb 21, 2023
@github-project-automation github-project-automation bot moved this from Under review to Done in Release v1.8.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wazsone wazsone

Labels
bug Something isn't working
Projects
Release v1.8.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wazsone @denis-tingaikin