-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linter #584
Merged
denis-tingaikin
merged 6 commits into
networkservicemesh:update/networkservicemesh/sdk
from
wazsone:bug/fix-linter
Feb 20, 2023
Merged
Fix linter #584
denis-tingaikin
merged 6 commits into
networkservicemesh:update/networkservicemesh/sdk
from
wazsone:bug/fix-linter
Feb 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmbot
force-pushed
the
update/networkservicemesh/sdk
branch
from
February 16, 2023 09:36
efcd0a1
to
a424091
Compare
wazsone
force-pushed
the
bug/fix-linter
branch
from
February 17, 2023 06:11
72256b4
to
9982032
Compare
nsmbot
force-pushed
the
update/networkservicemesh/sdk
branch
from
February 17, 2023 11:02
a424091
to
3e1b5ab
Compare
denis-tingaikin
approved these changes
Feb 18, 2023
@wazsone Could you please resolve conflicts? |
…k@main PR link: networkservicemesh/sdk#1419 Commit: 438ec05 Author: Denis Tingaikin Date: 2023-02-14 04:39:43 +0300 Message: - Moved to using a generic map instead of generated maps (#1419) * Moved to using a generic map instead of generated maps Signed-off-by: Ed Warnicke <hagbard@gmail.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix yammlit failture Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: Ed Warnicke <hagbard@gmail.com> Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
wazsone
force-pushed
the
bug/fix-linter
branch
from
February 20, 2023 03:15
9982032
to
e242333
Compare
Signed-off-by: Ruslan Bayandinov <45530296+wazsone@users.noreply.github.com>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
denis-tingaikin
approved these changes
Feb 20, 2023
denis-tingaikin
merged commit Feb 20, 2023
f947341
into
networkservicemesh:update/networkservicemesh/sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #583
Related to networkservicemesh/sdk#1420