Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved to using a generic map instead of generated maps #1419

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Conversation

denis-tingaikin
Copy link
Member

Description

Replaces a ton of geterated code with go generics!
Closes #1350

Issue link

#1350

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

edwarnicke and others added 2 commits February 13, 2023 17:55
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@3aa9aa0). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1419   +/-   ##
=======================================
  Coverage        ?   69.61%           
=======================================
  Files           ?      246           
  Lines           ?    11058           
  Branches        ?        0           
=======================================
  Hits            ?     7698           
  Misses          ?     2860           
  Partials        ?      500           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit 438ec05 into main Feb 14, 2023
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 14, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@denis-tingaikin denis-tingaikin self-assigned this Feb 14, 2023
wazsone pushed a commit to wazsone/cmd-nsmgr that referenced this pull request Feb 20, 2023
…k@main

PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
denis-tingaikin pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 20, 2023
* Update go.mod and go.sum to latest version from networkservicemesh/sdk@main
PR link: networkservicemesh/sdk#1419

Commit: 438ec05
Author: Denis Tingaikin
Date: 2023-02-14 04:39:43 +0300
Message:
  - Moved to using a generic map instead of generated maps (#1419)
* Moved to using a generic map instead of generated maps

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yammlit failture

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* fix linter

Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>

* fix merge

Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>

* fix dependencies

Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>

* update generated files

Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>

---------

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <45530296+wazsone@users.noreply.github.com>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants