Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable control characters in logs #1594

Closed
bszirtes opened this issue Mar 13, 2024 · 3 comments
Closed

Option to disable control characters in logs #1594

bszirtes opened this issue Mar 13, 2024 · 3 comments
Assignees

Comments

@bszirtes
Copy link
Contributor

It would be nice if there were an option to disable coloring and remove control characters from the logs.

bszirtes added a commit to Nordix/nsm-sdk that referenced this issue Mar 14, 2024
@denis-tingaikin
Copy link
Member

Hello @bszirtes ,

We think that we can just remove some control characters in logs without options.

Could you also attach an example of logs with colouring and control characters that you would like to remove?

@bszirtes
Copy link
Contributor Author

bszirtes commented Mar 14, 2024

Hello @denis-tingaikin,

The control characters we want to exclude from the logs are closely related to the coloring, to the best of my knowledge. We would like to avoid the following:

Feb 22 06:38:57.984.[36m [INFO] [cmd:/bin/forwarder] .[0mStartup completed in 7.874008959s

Instead, what we would like to have are the plain logs:

Nov 15 14:39:42.385 [INFO] [cmd:/bin/forwarder] Startup completed in 5.65923051

@bszirtes bszirtes mentioned this issue Mar 14, 2024
9 tasks
bszirtes added a commit to Nordix/nsm-sdk that referenced this issue Mar 14, 2024
NSM issue: networkservicemesh#1594

Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
@denis-tingaikin
Copy link
Member

As far as I know, we don't have colouring. Also, I suggest just removing all control symbols and not adding new options.

bszirtes added a commit to Nordix/nsm-sdk that referenced this issue Mar 14, 2024
NSM issue: networkservicemesh#1594

Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
bszirtes added a commit to Nordix/nsm-sdk that referenced this issue Mar 14, 2024
NSM issue: networkservicemesh#1594

Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
bszirtes added a commit to Nordix/nsm-sdk that referenced this issue Mar 18, 2024
NSM issue: networkservicemesh#1594

Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
bszirtes added a commit to Nordix/nsm-sdk that referenced this issue Mar 18, 2024
NSM issue: networkservicemesh#1594

Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
bszirtes added a commit to Nordix/nsm-sdk that referenced this issue Mar 18, 2024
NSM issue: networkservicemesh#1594

Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
bszirtes added a commit to Nordix/nsm-sdk that referenced this issue Mar 18, 2024
NSM issue: networkservicemesh#1594

Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
denis-tingaikin pushed a commit that referenced this issue Mar 19, 2024
NSM issue: #1594

Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-dashboard-backend that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this issue Mar 19, 2024
…k@main

PR link: networkservicemesh/sdk#1595

Commit: a9e38d9
Author: Botond Szirtes
Date: 2024-03-19 10:04:55 +0100
Message:
  - Introducing option to disable log coloring (#1595)
NSM issue: networkservicemesh/sdk#1594

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants