Disable log coloring #1595
Merged
Disable log coloring #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
=======================================
Coverage ? 67.31%
=======================================
Files ? 261
Lines ? 12380
Branches ? 0
=======================================
Hits ? 8333
Misses ? 3524
Partials ? 523 ☔ View full report in Codecov by Sentry. |
bszirtes
force-pushed
the
disable-log-coloring
branch
from
5c4d080
to
65b0cd1
Compare
Comment on lines
37
to
39
| if os.Getenv("LOG_NOCOLORS") == "true" { | ||
| f.nf.NoColors = true | ||
| } |
There was a problem hiding this comment.
Let's use this behaviour by default. I don't see any problems on our side. So if it's also fine for your side, let's do it.
There was a problem hiding this comment.
Are you suggesting removing the verification process and adopting the f.nf.NoColors = true behavior as the default?
There was a problem hiding this comment.
Yes, it's correct. I don't see any motivation for using these control symbols so we can just cut it.
There was a problem hiding this comment.
That would be fine from our side, I will update my commit accordingly.
There was a problem hiding this comment.
Hello @denis-tingaikin,
I edited my commit and changed the default behavior based on the discussion. However, some of the CI tests failed, and upon reviewing the results, it seems that some expected outputs explicitly contain the control characters that I have removed.
...
--- FAIL: TestOutput (0.00s)
common_test.go:73:
Error Trace: /home/runner/work/sdk/sdk/pkg/networkservice/core/trace/traceconcise/common_test.go:73
Error: Not equal:
expected: "\x1b[36m [INFO] [id:conn-1] [type:networkService] \x1b[0mserver-reque...
...
Do you have any suggestions on how to proceed?
There was a problem hiding this comment.
Since we're removing control characters from logs, we should also remove them from expectations in tests.
bszirtes
force-pushed
the
disable-log-coloring
branch
2 times, most recently
from
dcef1a8
to
34f2ed5
Compare
bszirtes
changed the title
bszirtes
force-pushed
the
disable-log-coloring
branch
3 times, most recently
from
7ad16d8
to
307a9c8
Compare
denis-tingaikin
approved these changes
Mar 18, 2024
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) 2021 Doc.ai and/or its affiliates. | |||
| // Copyright (c) 2024 Doc.ai and/or its affiliates. | |||
There was a problem hiding this comment.
It's better to use a year range (2021-2024) for these cases.
Please check other modified files
There was a problem hiding this comment.
Okay, I will update the files accordingly. What should I put into the header where it was
// Copyright (c) 2023 Cisco and/or its affiliates.
originally. Should I go with 2024, 2023-2024 or just use 2021-2024 everywhere?
There was a problem hiding this comment.
The first year should be the same.
So, you should use 2023-2024
There was a problem hiding this comment.
@bszirtes also feel free to use copyright holders related to your company ;)
For example,
// Copyright (c) 2023 Cisco and/or its affiliates.
//
// Copyright (c) 2024 My company and/or its affiliates.
//The copyright header is correct for the linter.
There was a problem hiding this comment.
I have made updates to the headers.
NSM issue: networkservicemesh#1594 Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
bszirtes
force-pushed
the
disable-log-coloring
branch
from
307a9c8
to
4ab043b
Compare
glazychev-art
approved these changes
Mar 19, 2024
denis-tingaikin
approved these changes
Mar 19, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1595 Commit: a9e38d9 Author: Botond Szirtes Date: 2024-03-19 10:04:55 +0100 Message: - Introducing option to disable log coloring (#1595) NSM issue: networkservicemesh/sdk#1594 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced an option to disable the coloring of the log messages and thus remove the control characters responsible for it, via an optionally defined environmental variable.
Issue link
#1594
How Has This Been Tested?
Types of changes