Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support NO_ORG job filtering #2098

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Conversation

zubenkoivan
Copy link
Contributor

closes #2096

Copy link
Contributor

@YevheniiSemendiak YevheniiSemendiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

platform_api/handlers/jobs_handler.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #2098 (984128e) into master (b908c8a) will decrease coverage by 22.42%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2098       +/-   ##
===========================================
- Coverage   92.15%   69.74%   -22.42%     
===========================================
  Files          41       41               
  Lines        7317     7327       +10     
  Branches     1090     1091        +1     
===========================================
- Hits         6743     5110     -1633     
- Misses        429     2101     +1672     
+ Partials      145      116       -29     
Flag Coverage Δ
integration ?
unit 69.74% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
platform_api/config.py 99.45% <100.00%> (-0.55%) ⬇️
platform_api/handlers/jobs_handler.py 56.99% <100.00%> (-33.19%) ⬇️

... and 25 files with indirect coverage changes

@zubenkoivan zubenkoivan merged commit 3ef5d76 into master Jun 5, 2023
@zubenkoivan zubenkoivan deleted the iz/add-no-org-job-filtering branch June 5, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support job filtering with explicit NO_ORG
2 participants