Skip to content

Commit

Permalink
[ENH] Clarify PR merging responsibility (#124)
Browse files Browse the repository at this point in the history
* clarify PR merge responsibility

* better differentiate PRs internal vs. external to developer team
  • Loading branch information
alyssadai authored Nov 13, 2023
1 parent 52db95c commit 8f4c5c2
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion docs/contributing/pull_requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Instead, for documentation content changes, the following prefixes can be used t
- `[FIX]`: Fixing errors in the documentation

## Pull request reviews
A developer will review each PR and may provide comments or suggestions for the PR author to address.
A core maintainer will review each PR and may provide comments or suggestions for the PR author to address.

Neurobagel PR reviews may use the following emoji signifiers:

Expand All @@ -31,3 +31,8 @@ Neurobagel PR reviews may use the following emoji signifiers:
:cherries:: Some optional/suggested changes that could be nice to have but are not required to merge

If (required) changes are requested, the PR author should re-request a review from the reviewer once the comments have been addressed.

### When your pull request is approved
If you **are not a member of the Neurobagel developer team**: the reviewing Neurobagel maintainer is responsible for merging the PR.

If you **are a member of the Neurobagel developer team** (i.e., you have write access to the repository): the PR author is responsible for merging the PR.

0 comments on commit 8f4c5c2

Please sign in to comment.