-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Added a subsection for participant-level results tsv in aggregate mode #105
Conversation
✅ Deploy Preview for neurobagel-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two 🍒, otherwise 🧑🍳 !
I can message the nipoppy folks regarding the broken link. Could you open an issue to update the markdown-link-check
config to ignore the broken SNOMED URL?
EDIT: Michelle has fixed the nipoppy link, and somehow the SNOMED URL redirection issue has fixed itself. I think all that's left to do is update this branch with the changes to main
!
@rmanaem, I had another thought. What do you think about also updating the graph setup page in this PR to explicitly point to the query tool documentation page (https://neurobagel.org/query_tool/) for more info on running cohort queries? i.e., maybe in this section documentation/docs/infrastructure.md Line 146 in 12bccc3
and/or this documentation/docs/infrastructure.md Line 189 in 12bccc3
Could be as simple as adding a line The goal would be letting sysadmins know very clearly where to look for more info about the query tool results, etc. in case they are testing out the query tool immediately after deployment. |
Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com>
Closes #97
Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX