Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Added a subsection for participant-level results tsv in aggregate mode #105

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 12, 2023

Closes #97

Checklist

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit 5fa291b
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/6532bb10c32300000878359d
😎 Deploy Preview https://deploy-preview-105--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alyssadai alyssadai self-requested a review October 12, 2023 15:15
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two 🍒, otherwise 🧑‍🍳 !

I can message the nipoppy folks regarding the broken link. Could you open an issue to update the markdown-link-check config to ignore the broken SNOMED URL?

EDIT: Michelle has fixed the nipoppy link, and somehow the SNOMED URL redirection issue has fixed itself. I think all that's left to do is update this branch with the changes to main!

docs/query_tool.md Outdated Show resolved Hide resolved
docs/query_tool.md Outdated Show resolved Hide resolved
@alyssadai
Copy link
Contributor

@rmanaem, I had another thought. What do you think about also updating the graph setup page in this PR to explicitly point to the query tool documentation page (https://neurobagel.org/query_tool/) for more info on running cohort queries?

i.e., maybe in this section

However, in many cases you may want to make the API accessible by a frontend tool such as our [browser query tool](https://github.com/neurobagel/query-tool).

and/or this

By default, this will also deploy a local version of the [Neurobagel graphical query tool](https://github.com/neurobagel/query-tool).

Could be as simple as adding a line For detailed instructions on using the query tool, see [Running cohort queries](link).

The goal would be letting sysadmins know very clearly where to look for more info about the query tool results, etc. in case they are testing out the query tool immediately after deployment.

@rmanaem rmanaem merged commit 0fe9c08 into main Oct 20, 2023
5 checks passed
@rmanaem rmanaem deleted the feat-97 branch October 20, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document differences between protected and non-protected participant-level TSV
2 participants