Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Correction suggestions related to local deployment of Neurobagel using graphDB #106

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

FPa-riken
Copy link
Contributor

@FPa-riken FPa-riken commented Oct 13, 2023

Correction suggestions related to local deployment of Neurobagel :

  • remove spurious trailing space which breaks multi-line command,
  • add graphDB specific command example,

Checklist

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit 57fddd5
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/652dcd78830dae00080fb5e4
😎 Deploy Preview https://deploy-preview-106--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FPa-riken FPa-riken changed the title [FIX] various fixes after setting up neurobagel/api using graphDB [FIX] Correction suggestions related to local deployment of Neurobagel using graphDB Oct 13, 2023
@alyssadai alyssadai self-requested a review October 13, 2023 19:13
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FPa-riken, welcome and thanks very much for your detailed corrections! 🎉

All your changes look good. One request before we merge this PR: would you mind merging the latest changes from main (includes fixes to some dead links) into this branch so that all the checks pass?

Once you do that, I can go ahead and merge the PR! 🙂

@FPa-riken
Copy link
Contributor Author

Hi, I've updated with latest from main, it should be fine to go ahead now. Thanks.

@alyssadai alyssadai merged commit b54513f into neurobagel:main Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants