Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Update info on assessment availability and following data model updates #123

Merged
merged 4 commits into from
Nov 13, 2023
Merged

[ENH] Update info on assessment availability and following data model updates #123

merged 4 commits into from
Nov 13, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Nov 13, 2023 •
edited by surchs
Loading

Checklist

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit 65a3868
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/65524f658fcb2d000873182d
😎 Deploy Preview https://deploy-preview-123--neurobagel-documentation.netlify.app/updating_dataset
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alyssadai alyssadai changed the title Update assessment availability encoding and add info for data model updates [ENH] Update assessment availability encoding and add info for data model updates Nov 13, 2023
@alyssadai alyssadai changed the title [ENH] Update assessment availability encoding and add info for data model updates [ENH] Update info on assessment availability and following data model updates Nov 13, 2023
surchs
surchs approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alyssadai! Looks good.

I made a couple of suggestions, mainly to clarify how we intend to treat breaking changes. I think we should soon have a discussion on how we want to handle breaking changes and whether we see .jsonld as ephemeral or not for now. I'll make an issue for that.

Take a look at the comments and then 🧑‍🍳

docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/updating_dataset.md Outdated Show resolved Hide resolved
docs/updating_dataset.md Outdated Show resolved Hide resolved
@surchs
Copy link
Contributor

surchs commented Nov 13, 2023

Referencing issues here:

alyssadai and others added 2 commits November 13, 2023 11:29
@alyssadai @surchs
Clarify treatment of breaking changes
f235089 
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
@alyssadai
Minor clarification
65a3868
@alyssadai alyssadai merged commit 52db95c into main Nov 13, 2023
5 checks passed
@alyssadai alyssadai deleted the update-assessment-info branch November 13, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document change to assessment tool missing value handling
2 participants
@alyssadai @surchs