Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Create a glossary for unclear terms #138

Merged
merged 11 commits into from
Dec 20, 2023
Merged

[ENH] Create a glossary for unclear terms #138

merged 11 commits into from
Dec 20, 2023

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Nov 28, 2023

Closes #44

Changes proposed in this pull request:

  • new glossary page
  • two sub-pages:
    • one for "generic terms"
    • one for "neurobagel specific" terms
  • a couple of term definitions (taken from the issue)

Each term is a 3rd level subheading. This allows us to use the sidebar navigation and we can also create links from inside the documentation to these terms. I am not sure that there is an automatic way to create these links - and I also don't think that we'd want that.

For reviewer: to keep this PR manageable, let's treat it more as a collaborative writing exercise: please provide direct edit suggestions where needed. For more substantial changes or additions let's create new issues.

Checklist

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit adea542
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/6583697c2cd6e30008e93d0f
😎 Deploy Preview https://deploy-preview-138--neurobagel-documentation.netlify.app/glossary
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

surchs and others added 4 commits November 28, 2023 16:25
@alyssadai alyssadai self-requested a review December 20, 2023 17:00
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @surchs for all your work on this!!

I've left another round of 🍒 edits as I realize, looking at the deploy preview, that the definitions for several terms are still quite long and some info could probably work better as admonitions.

Feel free to accept what makes sense to you!

docs/glossary.md Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Show resolved Hide resolved
surchs and others added 2 commits December 20, 2023 16:34
Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com>
@surchs surchs merged commit e42338b into main Dec 20, 2023
6 checks passed
@surchs surchs deleted the issue44 branch December 20, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a glossary for commonly used terms
2 participants