-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Create a glossary for unclear terms #138
Conversation
✅ Deploy Preview for neurobagel-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- combined two files - added updated definitions - added synonyms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @surchs for all your work on this!!
I've left another round of 🍒 edits as I realize, looking at the deploy preview, that the definitions for several terms are still quite long and some info could probably work better as admonitions.
Feel free to accept what makes sense to you!
Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com>
Closes #44
Changes proposed in this pull request:
Each term is a 3rd level subheading. This allows us to use the sidebar navigation and we can also create links from inside the documentation to these terms. I am not sure that there is an automatic way to create these links - and I also don't think that we'd want that.
For reviewer: to keep this PR manageable, let's treat it more as a collaborative writing exercise: please provide direct edit suggestions where needed. For more substantial changes or additions let's create new issues.
Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX