-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Made base_api_url an environment variable #37
Conversation
Hii @rmanaem, I have made the base_api_url an environment variable here. Please take a look and suggest any changes if required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Raya679!
I left suggestions to rename the env var to essentially mirror the env var we are already using in the query tool.
🍒 I think it's a good idea to have a way to make sure the new env var is set, throw an error to inform the user in case it's not and a test for that. Since the implementation simply concatenates the env var with the output from the llm to send the request, we can end up with http errors if the env var is not set properly. Let me know what you think.
Co-authored-by: Arman Jahanpour <77515879+rmanaem@users.noreply.github.com>
Co-authored-by: Arman Jahanpour <77515879+rmanaem@users.noreply.github.com>
Co-authored-by: Arman Jahanpour <77515879+rmanaem@users.noreply.github.com>
Hi @rmanaem , thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍒
Hii @rmanaem, I have made the changes. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧑🍳
Changes proposed in this pull request:
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: